Non-overflowing parse for signatures #67
Conversation
|
(Have to fix some issues on #65 before we can merge this!) |
| /// meaning you will have compatibility issues if you also use other | ||
| /// SECP256K! libraries. It's not recommended to use this function. Please | ||
| /// use `parse_standard` instead. | ||
| pub fn parse_overflowing(p: &[u8; util::SIGNATURE_SIZE]) -> Signature { |
There was a problem hiding this comment.
Any reason not to use #[deprecated(…)] here?
There was a problem hiding this comment.
deprecated imply that we can eventually remove this, which we cannot do. Same reason why der-lax is not marked deprecated.
There was a problem hiding this comment.
While that is true I’d probably use it anyway to get those nice compile time warnings. You could set the depreciation version very far out perhaps?
Either way, your call.
There was a problem hiding this comment.
I just think we simply can't get rid of it. In Substrate we'll have to create a new function version of this, with the old one always exist (and we cannot remove). In this sense, deprecated warning is just noise and not really useful.
We changed the function names, so when people upgrade they'll have a compile failure anyway and have to change the function name, which is more than safe enough to make sure they don't use the incorrect function.
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
|
Are there test vectors available that pass |
* Non-overflowing parse for signatures * Fix tests * Fix styling * Add docs for Signature struct functions * Update src/lib.rs Co-authored-by: David <dvdplm@gmail.com> * Update src/lib.rs Co-authored-by: David <dvdplm@gmail.com> * Update src/lib.rs Co-authored-by: David <dvdplm@gmail.com> * Update src/lib.rs Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: David <dvdplm@gmail.com>
This changes the current method to
parse_overflowingandparse_overflowing_slice, and a new non-overflowing signature parse function underparse_standardandparse_standard_slice.