Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kad: Ensure Kademlia Record has TTL #129

Closed
2 tasks done
Tracked by #140
lexnv opened this issue May 28, 2024 · 0 comments · Fixed by #162
Closed
2 tasks done
Tracked by #140

kad: Ensure Kademlia Record has TTL #129

lexnv opened this issue May 28, 2024 · 0 comments · Fixed by #162
Assignees
@dmitry-markin @lexnv

Comments

@lexnv
Copy link
Collaborator

lexnv commented May 28, 2024 •
edited
Loading

If the record received by kad::put_value does not have a TTL, use the default 36h expiry.

litep2p/src/protocol/libp2p/kademlia/record.rs

Lines 88 to 89 in 467a457

/// The expiration time as measured by a local, monotonic clock.
pub expires: Option<Instant>,

Tasks
Preview Give feedback
  1. kad: Set default ttl 36h for kad records #154
  2. kademlia: Preserve publisher & expiration time in DHT records #162
    bug
    dmitry-markin
@lexnv lexnv mentioned this issue Jun 4, 2024
Open
@lexnv lexnv mentioned this issue Jun 14, 2024
Merged
lexnv added a commit that referenced this issue Jun 14, 2024
@lexnv
kad: Set default ttl 36h for kad records (#154)
0778a02 
This PR introduces a default TTL for records.
- the default is set to 36h if the record ttl is unspecified
- this ensures the local memory store is not polluted with records
without TTL

Part of: #129

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv self-assigned this Jun 14, 2024
@dmitry-markin dmitry-markin mentioned this issue Jun 24, 2024
Merged
@dmitry-markin dmitry-markin moved this to Done ✅ in Networking Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-markin dmitry-markin

@lexnv lexnv

Labels
None yet
Projects
Networking
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kademlia: Preserve publisher & expiration time in DHT records paritytech/litep2p
2 participants
@dmitry-markin @lexnv