ping: Make ping fault tolerant wrt outbound substreams races #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
changed the title
dmitry-markin
approved these changes
May 29, 2024
Merged
dmitry-markin
added a commit
that referenced
this pull request
Jun 14, 2024
## [0.6.0] - 2024-06-14
This release introduces breaking changes into `kad` module. The API has
been extended as following:
- An event `KademliaEvent::IncomingRecord` has been added.
- New methods `KademliaHandle::store_record()` /
`KademliaHandle::try_store_record()` have been introduced.
This allows implementing manual incoming DHT record validation by
configuring `Kademlia` with `IncomingRecordValidationMode::Manual`.
Also, it is now possible to enable `TCP_NODELAY` on sockets.
Multiple refactorings to remove the code duplications and improve the
implementation robustness have been done.
### Added
- Support manual DHT record insertion
([#135](#135))
- transport: Make `TCP_NODELAY` configurable
([#146](#146))
### Changed
- transport: Introduce common listener for tcp and websocket
([#147](#147))
- transport/common: Share DNS lookups between TCP and WebSocket
([#151](#151))
### Fixed
- ping: Make ping fault tolerant wrt outbound substreams races
([#133](#133))
- crypto/noise: Make noise fault tolerant
([#142](#142))
- protocol/notif: Fix panic on missing peer state
([#143](#143))
- transport: Fix erroneous handling of secondary connections
([#149](#149))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have discovered a race between the TransportService and Protocol interface.
This issue was first seen on the identify protocol:
After looking a bit closely into it, indeed there might be a chance for the following to happen:
TransportEvent::ConnectionEstablishedandTransportEvent::SubstreamOpenedTransportEvent::ConnectionEstablishedevent for a disconnected peerPing::on_connection_establishedfails to open a substream andpending_openis never populatedTransportEvent::SubstreamOpenedevent which would have panicked litep2pThis PR replaces the
todo!in case of the race with a warning, and we'll no longer panic.It is still good to capture those as warnings for visibility, even if there's no implied side-effect on our code.