Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[pallet::storage_version to the all bridging pallets #2947

Closed
1 task
bkontur opened this issue Apr 12, 2024 · 2 comments
Closed
1 task

Add #[pallet::storage_version to the all bridging pallets #2947

bkontur opened this issue Apr 12, 2024 · 2 comments
Assignees
@bkontur
Milestone
Kusama <> Polkado...

Comments

@bkontur
Copy link
Contributor

bkontur commented Apr 12, 2024 •
edited
Loading

Relates to: #2794
Relates to: #1869

Addressing comments bellow: https://github.com/paritytech/parity-bridges-common/pull/2873/files#r1562376385

TODO

  • check try_state for bridging pallets
@bkontur bkontur mentioned this issue Apr 12, 2024
Closed
@bkontur bkontur self-assigned this Apr 12, 2024
This was referenced Apr 18, 2024
Open
Open
@bkontur bkontur mentioned this issue Apr 30, 2024
Closed
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue Apr 30, 2024
@bkontur
Setup storage_version for bridging pallets (#4337)
98b6b4a 
Closes: paritytech/parity-bridges-common#2947
@acatangiu
Copy link
Collaborator

from discussion in paritytech/polkadot-sdk#4337 it looks like we're not doing this anymore? (although I didn't understand why/how this is not useful anymore)

@bkontur @svyatonik wdyt? if not needed, we can close the issue

@bkontur
Copy link
Contributor Author

bkontur commented May 9, 2024

we will just add #[pallet::storage_version when needed

@bkontur bkontur closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkontur bkontur

Labels
None yet
Projects
Bridges + XCM
Status: Done
Milestone
Kusama <> Polkadot Parachain Bridge R...
Development

Successfully merging a pull request may close this issue.

Setup storage_version for bridging pallets paritytech/polkadot-sdk
2 participants
@bkontur @acatangiu