Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the wasm builder to substrate master #1029

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Jun 23, 2021

This PR updates the dependencies on substrate-wasm-builder from 3.0.0 to master. This allows benefiting from automatic generation of compressed wasm in adddition to the existing one.

After doing that change, I noticed that there was a single dependency left on 3.0.0, so I updated it as well have have everything in sync.

@chevdor
Copy link
Contributor Author

chevdor commented Jun 23, 2021

I am leaving this PR "as is" for now since the issues reported by the CI don't seem to be related to the changes.

@chevdor chevdor marked this pull request as ready for review June 23, 2021 17:52
@chevdor chevdor requested review from HCastano and tomusdrw June 23, 2021 17:52
@HCastano HCastano added A-chores Something that has to be done, as part of regular maintenance dependencies Pull requests that update a dependency file labels Jun 23, 2021
@HCastano HCastano changed the title chore: update the wasm builder to substrate master Update the wasm builder to substrate master Jun 23, 2021
@HCastano
Copy link
Contributor

I am leaving this PR "as is" for now since the issues reported by the CI don't seem to be related to the changes.

I think they are related. Can you bump Substrate (cargo update -p sp-io) and try again?

@chevdor chevdor merged commit bcde21d into paritytech:master Jun 25, 2021
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
* chore: update the wasm builder to substrate master
* Bump Substrate
* Update weight of sending remarks

ref paritytech/polkadot#3354

Co-authored-by: Hernando Castano <hernando@hcastano.com>
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
* chore: update the wasm builder to substrate master
* Bump Substrate
* Update weight of sending remarks

ref paritytech/polkadot#3354

Co-authored-by: Hernando Castano <hernando@hcastano.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chores Something that has to be done, as part of regular maintenance dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants