Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependecies #2277

Merged
merged 11 commits into from
Jul 19, 2023
Merged

Update dependecies #2277

merged 11 commits into from
Jul 19, 2023

Conversation

svyatonik
Copy link
Contributor

another deps update needed for #2261
the PR is not yet ready - just showing some progress on that

Unfortunately, I had to revert most of changes to bridges subtree from paritytech/cumulus#2790. I've missed the fact that the Block is now used in bridge primitives, which is not good - we don't have an access to extrinsic type there, so we don't (and won't need) to know the block type. So I'm reverting changes to our Chain trait. This also means that I'll backport those (my) changes to the polkadot-staging after merging this PR to master.

We also need to think of adding our crates to workspace level Cargo.toml in Cumulus. Some stuff here doesn't even compiles (my guess - haven't checked it in Cumulus subtree).

@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label Jul 17, 2023
@svyatonik svyatonik marked this pull request as ready for review July 19, 2023 10:32
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through, looks ok to me

@svyatonik svyatonik requested a review from a team as a code owner July 19, 2023 11:05
@svyatonik svyatonik removed the request for review from a team July 19, 2023 12:10
@svyatonik svyatonik merged commit af4609c into master Jul 19, 2023
@svyatonik svyatonik deleted the up-deps branch July 19, 2023 12:36
svyatonik added a commit that referenced this pull request Jul 19, 2023
* cargo update -p parachain-info

* flush

* it compiles

* clippy

* temporary add more logging to cargo deny

* Revert "temporary add more logging to cargo deny"

This reverts commit 20daa88.

* list installed Rust binaries before running cargo deny

* changed prev commit

* once again

* try cargo update?

* post-update fixes (nothing important)
svyatonik added a commit that referenced this pull request Jul 19, 2023
* cargo update -p parachain-info

* flush

* it compiles

* clippy

* temporary add more logging to cargo deny

* Revert "temporary add more logging to cargo deny"

This reverts commit 20daa88.

* list installed Rust binaries before running cargo deny

* changed prev commit

* once again

* try cargo update?

* post-update fixes (nothing important)
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
* cargo update -p parachain-info

* flush

* it compiles

* clippy

* temporary add more logging to cargo deny

* Revert "temporary add more logging to cargo deny"

This reverts commit 20daa88.

* list installed Rust binaries before running cargo deny

* changed prev commit

* once again

* try cargo update?

* post-update fixes (nothing important)
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
* cargo update -p parachain-info

* flush

* it compiles

* clippy

* temporary add more logging to cargo deny

* Revert "temporary add more logging to cargo deny"

This reverts commit 20daa88.

* list installed Rust binaries before running cargo deny

* changed prev commit

* once again

* try cargo update?

* post-update fixes (nothing important)
bkontur pushed a commit that referenced this pull request May 7, 2024
* cargo update -p parachain-info

* flush

* it compiles

* clippy

* temporary add more logging to cargo deny

* Revert "temporary add more logging to cargo deny"

This reverts commit 20daa88.

* list installed Rust binaries before running cargo deny

* changed prev commit

* once again

* try cargo update?

* post-update fixes (nothing important)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chores Something that has to be done, as part of regular maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants