-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to use InspectCmd, bump substrate 6bef4f4
#966
Conversation
Updated toolchain to try again, still same error as above
Needed to bump |
Thanks for the PR Dan! Since you're here anyways, do you mind bumping it to whatever the latest version of Substrate Polkadot is using when you pick this up again? |
Sure! I guess in the end it's a concrete commit, so it doesn't really matter, so pointing to master is best. Updated to |
4ff92f11
3f11019
Ah shoot, the release didn't include the reversion of the type name yet 🤦🏼 so it's failing here until polkadot bumps it's substrate past this commit I suppose. paritytech/substrate@4ff92f1 |
@nukemandan We don't want to follow releases, we want to track I figured Polkadot would be more caught up, but I guess there haven't been any breaking changes recently. |
Any updates here @nukemandan? |
https://github.com/paritytech/polkadot/releases/tag/v0.9.2 now includes the right substrate stuff 🥳 Update: builds locally just fine, substrate |
3f11019
6bef4f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* revert to use InspectCmd * rust toolchain 1.52 * Bump `finality-grandpa` and `parity-scale-codec` * bump to same version for substrate as polkadot v0.9.1 * bump to polkadot 0.9.2 deps for substrate `6bef4f4` Co-authored-by: Hernando Castano <hernando@hcastano.com>
* revert to use InspectCmd * rust toolchain 1.52 * Bump `finality-grandpa` and `parity-scale-codec` * bump to same version for substrate as polkadot v0.9.1 * bump to polkadot 0.9.2 deps for substrate `6bef4f4` Co-authored-by: Hernando Castano <hernando@hcastano.com>
Cargo.lock
to paritytech/substrate@4ff92f1b094edaf
#958 with InspectKeyCmd, reverted to InspectCmdPresently doesn't build, fails on dependency in
frame-support