Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to use InspectCmd, bump substrate 6bef4f4 #966

Merged
merged 5 commits into from
May 20, 2021

Conversation

nuke-web3
Copy link
Contributor

Presently doesn't build, fails on dependency in frame-support

error: could not compile `frame-support`
error[E0277]: the trait bound `[T; N]: WrapperTypeEncode` is not satisfied
  --> cargo/git/checkouts/substrate-7e08433d4c370a21/4ff92f1/frame/support/src/traits/max_encoded_len.rs:82:40
   |
28 | pub trait MaxEncodedLen: Encode {
   |                          ------ required by this bound in `MaxEncodedLen`
...
82 | impl<T: MaxEncodedLen, const N: usize> MaxEncodedLen for [T; N] {
   |                                        ^^^^^^^^^^^^^ the trait `WrapperTypeEncode` is not implemented for `[T; N]`
   |
   = note: required because of the requirements on the impl of `_::_parity_scale_codec::Encode` for `[T; N]`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.

@nuke-web3 nuke-web3 requested a review from tomusdrw May 12, 2021 16:39
@nuke-web3 nuke-web3 marked this pull request as draft May 12, 2021 16:40
@nuke-web3
Copy link
Contributor Author

Updated toolchain to try again, still same error as above

  stable-x86_64-unknown-linux-gnu unchanged - rustc 1.52.1 (9bc8c42bb 2021-05-09)
  nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.54.0-nightly (5c0292654 2021-05-11)

Needed to bump cargo update -p environmental here to account for this.

@HCastano
Copy link
Contributor

Thanks for the PR Dan!

Since you're here anyways, do you mind bumping it to whatever the latest version of Substrate Polkadot is using when you pick this up again?

@nuke-web3
Copy link
Contributor Author

nuke-web3 commented May 13, 2021

Sure! To clarify, you want what the master branch using or the latest release - they happen to both be 3f11019 , so I can use that here. We can specify the release tag instead of master in the full URL for the Cargo.lock file if you would prefer that? Or ( assume) you mean to track master?

I guess in the end it's a concrete commit, so it doesn't really matter, so pointing to master is best. Updated to 3f11019

@nuke-web3 nuke-web3 changed the title Revert to use InspectCmd, bump substrate 4ff92f11 Revert to use InspectCmd, bump substrate 3f11019 May 13, 2021
@nuke-web3 nuke-web3 marked this pull request as ready for review May 13, 2021 02:56
@nuke-web3
Copy link
Contributor Author

Ah shoot, the release didn't include the reversion of the type name yet 🤦🏼 so it's failing here until polkadot bumps it's substrate past this commit I suppose. paritytech/substrate@4ff92f1

@nuke-web3 nuke-web3 marked this pull request as draft May 13, 2021 03:07
@nuke-web3 nuke-web3 removed the request for review from tomusdrw May 13, 2021 03:07
@nuke-web3 nuke-web3 added dependencies Pull requests that update a dependency file A-chores Something that has to be done, as part of regular maintenance labels May 13, 2021
@HCastano
Copy link
Contributor

@nukemandan We don't want to follow releases, we want to track master, so bumping to Substrate c5f1ca65 should be fine.

I figured Polkadot would be more caught up, but I guess there haven't been any breaking changes recently.

@HCastano
Copy link
Contributor

Any updates here @nukemandan?

@nuke-web3
Copy link
Contributor Author

nuke-web3 commented May 20, 2021

https://github.com/paritytech/polkadot/releases/tag/v0.9.2 now includes the right substrate stuff 🥳
will bump to that presently, then this should be gtg.

Update: builds locally just fine, substrate 6bef4f4

@nuke-web3 nuke-web3 requested a review from HCastano May 20, 2021 17:07
@nuke-web3 nuke-web3 marked this pull request as ready for review May 20, 2021 17:07
@nuke-web3 nuke-web3 changed the title Revert to use InspectCmd, bump substrate 3f11019 Revert to use InspectCmd, bump substrate 6bef4f4 May 20, 2021
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HCastano HCastano merged commit 68d6d79 into master May 20, 2021
@HCastano HCastano deleted the bump-substrate-`4ff92f1` branch May 20, 2021 17:43
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
* revert to use InspectCmd

* rust toolchain 1.52

* Bump `finality-grandpa` and `parity-scale-codec`

* bump to same version for substrate as polkadot v0.9.1

* bump to polkadot 0.9.2 deps for substrate `6bef4f4`

Co-authored-by: Hernando Castano <hernando@hcastano.com>
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
* revert to use InspectCmd

* rust toolchain 1.52

* Bump `finality-grandpa` and `parity-scale-codec`

* bump to same version for substrate as polkadot v0.9.1

* bump to polkadot 0.9.2 deps for substrate `6bef4f4`

Co-authored-by: Hernando Castano <hernando@hcastano.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chores Something that has to be done, as part of regular maintenance dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants