Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryDB can't derive default #8

Closed
dvdplm opened this issue Jul 11, 2018 · 0 comments · Fixed by #9
Closed

MemoryDB can't derive default #8

dvdplm opened this issue Jul 11, 2018 · 0 comments · Fixed by #9

Comments

@dvdplm
Copy link
Contributor

dvdplm commented Jul 11, 2018

Due to how we handle null nodes in memorydb – by calculating them on instantiation – we can't use MemoryDB::default() as a synonym for MemoryDB::new().

Do one of three things:

  1. fix the null node instantiation hack (come talk to me or @rphmeier first)
  2. remove #[derive(Default)] and fix all code that uses MemoryDB::default()
  3. implement Default properly
dvdplm added a commit that referenced this issue Jul 11, 2018
Version bump: 0.2.1

Closes #8
dvdplm pushed a commit that referenced this issue Jul 13, 2018
* feature(asm) is only allowed in crate

* add tests/build.rs again - haven't found a way around it
dvdplm pushed a commit that referenced this issue Jul 13, 2018
* feature(asm) is only allowed in crate

* add tests/build.rs again - haven't found a way around it
sorpaas pushed a commit that referenced this issue Jan 24, 2019
* feature(asm) is only allowed in crate

* add tests/build.rs again - haven't found a way around it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant