Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rand to 0.7 (breaking change) #217

Merged
merged 7 commits into from
Oct 1, 2019
Merged

update rand to 0.7 (breaking change) #217

merged 7 commits into from
Oct 1, 2019

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Sep 5, 2019 •
edited
Loading

Updates a bunch of crates to use rand 0.7.

It is needed by openethereum/parity-ethereum#11022 but I don't know if it makes sense anymore see rustsec/advisory-db#149 for details.

We could put it on ice if it is too messy

@dvdplm
Copy link
Contributor

dvdplm commented Sep 5, 2019

What is the rationale for 0.7?

@niklasad1
Copy link
Member Author

niklasad1 commented Sep 5, 2019 •
edited
Loading

What is the rationale for 0.7?

It is needed by openethereum/parity-ethereum#11022 but I don't know if it makes sense anymore see rustsec/advisory-db#149 for details.

We could put it on ice if it is too messy

ordian
ordian reviewed Sep 5, 2019
View reviewed changes
fixed-hash/src/hash.rs Show resolved Hide resolved
kvdb-rocksdb/Cargo.toml Outdated Show resolved Hide resolved
keccak-hash/Cargo.toml Show resolved Hide resolved
ordian
ordian reviewed Sep 5, 2019
View reviewed changes
rlp/Cargo.toml Outdated Show resolved Hide resolved
@niklasad1 niklasad1 marked this pull request as ready for review September 8, 2019 08:14
@niklasad1 niklasad1 mentioned this pull request Sep 10, 2019
Merged
@ordian ordian mentioned this pull request Sep 22, 2019
Merged
@dvdplm dvdplm mentioned this pull request Oct 1, 2019
Merged
dvdplm
dvdplm approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a bit annoying to publish but not too bad I guess.

@dvdplm dvdplm merged commit 1e9f990 into master Oct 1, 2019
@niklasad1 niklasad1 deleted the na-rand-0.7 branch October 1, 2019 10:51
@dvdplm
Copy link
Contributor

dvdplm commented Oct 1, 2019 •
edited
Loading

Published a few new versions:

* [new tag]             ethbloom-v0.8.0 -> ethbloom-v0.8.0
* [new tag]             fixed-hash-v0.5.0 -> fixed-hash-v0.5.0
* [new tag]             primitive-types-v0.6.0 -> primitive-types-v0.6.0
* [new tag]             ethereum-types-v0.8.0 -> ethereum-types-v0.8.0
* [new tag]             keccak-hash-v0.4.0 -> keccak-hash-v0.4.0

Still need to publish contract-address-0.3.0 (cc @ordian)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordian ordian ordian approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niklasad1 @dvdplm @tomusdrw @ordian