Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare new kvdb- release #386

Merged
merged 4 commits into from
May 5, 2020
Merged

prepare new kvdb- release #386

merged 4 commits into from
May 5, 2020

Conversation

ordian
Copy link
Member

@ordian ordian commented May 1, 2020

  • kvdb 0.6
  • kvdb-memorydb 0.6
  • kvdb-rocksdb 0.8
  • kvdb-web 0.6

dvdplm
dvdplm approved these changes May 1, 2020
View reviewed changes
kvdb-web/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog].
[Keep a Changelog]: http://keepachangelog.com/en/1.0.0/

## [Unreleased]

## [0.6.0] - 2020-05-01
### Breaking
- Updated to the new `kvdb` interface. [#313](https://github.com/paritytech/parity-common/pull/313)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given a lot happened here, I wouldn't mind a bit more info on what happened here, totally optional ofc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean copy kvdb changelog changes to every impl's changelog (kvdb-memorydb, kvdb-rocksdb, kvdb-web)?

ordian added 2 commits May 1, 2020 17:24
@ordian
kvdb-rocksdb: mark second instance as breaking
f4d3f79 
It added a public field to a public struct
`DatabaseConfig`.
@ordian
maybe today is the day?
920d4fb
@dvdplm
Copy link
Contributor

dvdplm commented May 5, 2020

@niklasad1 @ascjones @sorpaas can we get a 👍 here please?

ascjones
ascjones approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ordian ordian merged commit 844f899 into master May 5, 2020
@ordian ordian deleted the ao-prepare-rockdsb-release branch May 5, 2020 12:21
@ordian
Copy link
Member Author

ordian commented May 5, 2020

Published.

ordian added a commit that referenced this pull request Jun 12, 2020
@ordian
Merge branch 'master' into ao-type-metadata
5afa279 
* master:
  uint: manually implement `Eq` and `Hash` (#390)
  uint: simplify `Ord` impl (#389)
  Implement codec for ethereum types (#393)
  update changelogs and bump versions (#387)
  prepare new `kvdb-` release (#386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ascjones ascjones ascjones approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
A2-insubstantial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ordian @dvdplm @ascjones @niklasad1