Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to rust 2021 #601

Merged
merged 4 commits into from
Nov 21, 2021
Merged

move to rust 2021 #601

merged 4 commits into from
Nov 21, 2021

Conversation

nuke-web3
Copy link
Contributor

@nuke-web3 nuke-web3 commented Nov 14, 2021 •
edited
Loading

Confirmed to build locally on Ubuntu 20.04.3 LTS:

rustc 1.56.1 (59eed8a2a 2021-11-01)
rustc 1.58.0-nightly (e90c5fbbc 2021-11-12)

@nuke-web3 nuke-web3 requested a review from ordian November 14, 2021 01:54
ordian
ordian approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be good to document in the changelogs that the minimum required rust version (MSVR) is now bumped to 1.56.

@nuke-web3
Copy link
Contributor Author

Thanks! It would be good to document in the changelogs that the minimum required rust version (MSVR) is now bumped to 1.56.

Updated and added MSRV 1.56.1, for discussion on why: libp2p/rust-libp2p#2339
Also removed the reslover = 2 as that's no longer needed, and for a few missing CHANGELOG files, now added to all crates and all crates are 2021 + 1.56.1

@nuke-web3 nuke-web3 requested a review from ordian November 21, 2021 03:30
ordian
ordian reviewed Nov 21, 2021
View reviewed changes
uint/fuzz/CHANGELOG.md Outdated
[Keep a Changelog]: http://keepachangelog.com/en/1.0.0/

## [Unreleased]
- Migrated to 2021 edition, enforcing MSRV of `1.56.1`. [#601](https://github.com/paritytech/parity-common/pull/601)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this crate is not going to be published

@ordian ordian merged commit c3ef97d into master Nov 21, 2021
@ordian ordian deleted the ds/2021 branch November 21, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordian ordian ordian approved these changes

@KiChjang KiChjang KiChjang approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nuke-web3 @dvdplm @KiChjang @ordian