Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to re-export parity-scale-codec crate #325

Merged
merged 6 commits into from
Mar 4, 2022
Merged

Add ability to re-export parity-scale-codec crate #325

merged 6 commits into from
Mar 4, 2022

Conversation

gshep
Copy link
Contributor

@gshep gshep commented Feb 20, 2022

Closes #323

bkchr
bkchr reviewed Feb 20, 2022
View reviewed changes
derive/src/lib.rs Outdated Show resolved Hide resolved
derive/src/lib.rs Outdated Show resolved Hide resolved
@gshep
Copy link
Contributor Author

gshep commented Mar 1, 2022

@bkchr Could you take a look one more time?

CI failed with the error: error: linker clang-13 not found

bkchr
bkchr approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@bkchr
Copy link
Member

bkchr commented Mar 3, 2022

@gshep can you merge master to make the CI happy?

@gshep
Copy link
Contributor Author

gshep commented Mar 3, 2022

@gshep can you merge master to make the CI happy?

Unfortunately this didn't help. CI fails now with the following:

Fresh parity-scale-codec v3.1.0 (/builds/parity/parity-scale-codec)
    Finished test [unoptimized + debuginfo] target(s) in 23.26s
     Running `/ci-cache/parity-scale-codec/targets/325/test-rust-stable-no_derive/debug/deps/parity_scale_codec-c67a3a418efa0b13`
/ci-cache/parity-scale-codec/targets/325/test-rust-stable-no_derive/debug/deps/parity_scale_codec-c67a3a418efa0b13:
 /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.29' not found (required by /ci-cache/parity-scale-codec/targets/325/test-rust-stable-no_derive/debug/deps/parity_scale_codec-c67a3a418efa0b13)
error: test failed, to rerun pass '--lib'

@bkchr
Copy link
Member

bkchr commented Mar 3, 2022

@alvicsam any idea what is happening here? How can it happen that we don't find the glibc we are building with?

@alvicsam
Copy link
Contributor

alvicsam commented Mar 4, 2022

Cleaned CI cache, rerun the job - now CI is happy

@bkchr bkchr merged commit b860411 into paritytech:master Mar 4, 2022
@gshep gshep deleted the issue-323 branch March 4, 2022 10:51
@gshep gshep restored the issue-323 branch March 4, 2022 11:25
@gshep gshep deleted the issue-323 branch March 4, 2022 11:26
@gshep
Copy link
Contributor Author

gshep commented Mar 5, 2022 •
edited
Loading

@bkchr What should be done next? Tags parity-scale-codec(-derive)-v3.1.0? What about to publish this version to crates.io?

@bkchr
Copy link
Member

bkchr commented Mar 12, 2022

Sorry for the delay. I published them :)

HCastano added a commit to use-ink/ink that referenced this pull request Mar 15, 2022
@HCastano
Specify path to parity-scale-codec crate
7457a3f 
Related PR: paritytech/parity-scale-codec#325
@HCastano HCastano mentioned this pull request Mar 15, 2022
Merged
@HCastano
Copy link

@gshep FYI, this broke our build of ink!: use-ink/ink#1180 😅

cmichi pushed a commit to use-ink/ink that referenced this pull request Mar 15, 2022
@HCastano
Fix build after SCALE v3.1 update (#1180)
c974cde 
* Fix some UI tests for parity_scale_codec `3.1`

* Specify path to `parity-scale-codec` crate

Related PR: paritytech/parity-scale-codec#325
@gshep
Copy link
Contributor Author

gshep commented Mar 15, 2022

@gshep FYI, this broke our build of ink!: paritytech/ink#1180 sweat_smile

ah, shame on me =) .

Frankly speaking there is one more that could make some issues - paritytech/scale-info#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: ability to reexport codec crate
4 participants
@gshep @bkchr @alvicsam @HCastano