-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all clippy warnings and add clippy to the CI #455
Fix all clippy warnings and add clippy to the CI #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a Clippy config file?
Could be the one from Substrate in .cargo/config.toml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some Qs.
Hmmm.... I think we should be fine with the default one here, as this is orders of magnitude smaller so we don't need to disable a bunch of lints like in Substrate. |
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Its not just disabling, it is also denying some. But only |
Clippy doesn't like the theoretically redundant closure calls that I've added in my last PR, and since clippy doesn't run on the CI here I didn't notice.
While I was at it I also fixed all other clippy warnings, plus one error as it was complaining about an
unsafe
that I've now removed. I've also added clippy to the CI (hopefully it works).Fixes #454
Fixes #456