-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix max_encoded_len for Compact fields #508
Conversation
also a few side thoughts: |
I mean we probably never use more than
const fn trait functions are not supported right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks, otherwise looks good 👍
Good work :)
Co-authored-by: Bastian Köcher <git@kchr.de>
@pgherveou could you release |
isnt 3.6.5 the current version, you mean 3.6.6? |
Noticed that when using compact fields the max_encoded_len macro expand to the same as if we were not using the compact attribute.
Will expand to
This PR fix it to