Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing winerror feature #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pronebird
Copy link

This PR fixes Cargo.toml that mentions winbase feature twice for winapi-rs but lacks winerror that prevents compilation with the latest winapi-rs 0.3.9.

error[E0432]: unresolved import `winapi::shared::winerror`
 --> C:\Users\pronebird\.cargo\registry\src\index.crates.io-6f17d22bba15001f\parity-tokio-ipc-0.9.0\src\win.rs:1:21
  |
1 | use winapi::shared::winerror::{ERROR_PIPE_BUSY, ERROR_SUCCESS};
  |                     ^^^^^^^^ could not find `winerror` in `shared`

@jmwample
Copy link

:Bump:

Is there any chance of getting this merged and added in a release? If not this crate will break in any projects hoping to build for windows in the future. If this project is EoL or unmaintained that is fine I can look for something else to use in place of this.

@Xanewok not sure if you are the proper person to poke, but you have several of the most recent commits on this crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants