Skip to content

Commit

Permalink
PVF: Remove artifact persistence across restarts (#2895)
Browse files Browse the repository at this point in the history
Considering the complexity of
#2871 and the discussion
therein, as well as the further complexity introduced by the hardening
in #2742, as well as the
eventual replacement of wasmtime by PolkaVM, it seems best to remove
this persistence as it is creating more problems than it solves.

## Related

Closes #2863
  • Loading branch information
mrcnski committed Jan 10, 2024
1 parent f2a750e commit 6a80c10
Show file tree
Hide file tree
Showing 11 changed files with 117 additions and 379 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions polkadot/node/core/pvf/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ workspace = true

[dependencies]
always-assert = "0.1"
array-bytes = "6.1"
blake3 = "1.5"
cfg-if = "1.0"
futures = "0.3.21"
Expand Down
3 changes: 0 additions & 3 deletions polkadot/node/core/pvf/common/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ seccompiler = "0.4.0"
assert_matches = "1.4.0"
tempfile = "3.3.0"

[build-dependencies]
substrate-build-script-utils = { path = "../../../../../substrate/utils/build-script-utils" }

[features]
# This feature is used to export test code to other crates without putting it in the production build.
test-utils = []
Expand Down
19 changes: 0 additions & 19 deletions polkadot/node/core/pvf/common/build.rs

This file was deleted.

2 changes: 0 additions & 2 deletions polkadot/node/core/pvf/common/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ pub use sp_tracing;

const LOG_TARGET: &str = "parachain::pvf-common";

pub const RUNTIME_VERSION: &str = env!("SUBSTRATE_WASMTIME_VERSION");

use parity_scale_codec::{Decode, Encode};
use std::{
io::{self, Read, Write},
Expand Down
Loading

0 comments on commit 6a80c10

Please sign in to comment.