Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parity-wasm dependency #20

Open
koute opened this issue Mar 1, 2023 · 1 comment
Open

Remove parity-wasm dependency #20

koute opened this issue Mar 1, 2023 · 1 comment
Labels
I4-refactor Code needs refactoring.

Comments

@koute
Copy link
Contributor

koute commented Mar 1, 2023

parity-wasm is deprecated and we aren't maintaining it anymore. (And we don't really want to.). We're using it for some light patching of WASM blobs. (And I guess wasmi still uses it, but that's going to change soon-ish when we upgrade the currently used ancient wasmi version to the newest one.)

There's the wasmparser and wasm-encoder crates (maintained by the same people who maintain wasmtime) to which we should most likely switch to.
@koute
Copy link
Contributor Author

koute commented Mar 1, 2023 •
edited
Loading

If we want to keep the ability to patch WASM blobs we'll have to convert wasmparser types into wasm-encoder types; this isn't necessarily hard (and it's really easy to fuzz, so I'm not worried about any possible correctness issues), just potentially tedious.

Fortunately this work has apparently already been done. There's a fork of our own wasm-instrument crate where they replaced the use of parity-wasm with wasmparser + wasm-encoder, so we could just reuse that.

@koute koute mentioned this issue Aug 24, 2023
Open
@the-right-joyce the-right-joyce transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. and removed I7-refactor labels Aug 25, 2023
andresilva added a commit that referenced this issue Mar 5, 2024
@andresilva
update schnorrkel to 0.11.4 (#20)
03f02a7
lexnv pushed a commit that referenced this issue Apr 3, 2024
@sergejparity
Merge pull request #20 from paritytech/sk-pin-gha-versions
0bad54f 
Pin GHA versions and add dependabot
github-merge-queue bot pushed a commit that referenced this issue Apr 8, 2024
@skunert @bkchr
Add best block indicator to informant message + print parent block on…
fdb1dba 
… import message (#4021)

Sometimes you need to debug some issues just by the logs and reconstruct
what happened.
In these scenarios it would be nice to know if a block was imported as
best block, and what it parent was.
So here I propose to change the output of the informant to this:

```
2024-04-05 20:38:22.004  INFO ⋮substrate: [Parachain] ✨ Imported #18 (0xe7b3…4555 -> 0xbd6f…ced7)    
2024-04-05 20:38:24.005  INFO ⋮substrate: [Parachain] ✨ Imported #19 (0xbd6f…ced7 -> 0x4dd0…d81f)    
2024-04-05 20:38:24.011  INFO ⋮substrate: [jobless-children-5352] 🌟 Imported #42 (0xed2e…27fc -> 0x718f…f30e)    
2024-04-05 20:38:26.005  INFO ⋮substrate: [Parachain] ✨ Imported #20 (0x4dd0…d81f -> 0x6e85…e2b8)    
2024-04-05 20:38:28.004  INFO ⋮substrate: [Parachain] 🌟 Imported #21 (0x6e85…e2b8 -> 0xad53…2a97)    
2024-04-05 20:38:30.004  INFO ⋮substrate: [Parachain] 🌟 Imported #22 (0xad53…2a97 -> 0xa874…890f)    
```

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Ank4n pushed a commit that referenced this issue Apr 9, 2024
@skunert @bkchr @Ank4n
Add best block indicator to informant message + print parent block on…
4db2dca 
… import message (#4021)

Sometimes you need to debug some issues just by the logs and reconstruct
what happened.
In these scenarios it would be nice to know if a block was imported as
best block, and what it parent was.
So here I propose to change the output of the informant to this:

```
2024-04-05 20:38:22.004  INFO ⋮substrate: [Parachain] ✨ Imported #18 (0xe7b3…4555 -> 0xbd6f…ced7)    
2024-04-05 20:38:24.005  INFO ⋮substrate: [Parachain] ✨ Imported #19 (0xbd6f…ced7 -> 0x4dd0…d81f)    
2024-04-05 20:38:24.011  INFO ⋮substrate: [jobless-children-5352] 🌟 Imported #42 (0xed2e…27fc -> 0x718f…f30e)    
2024-04-05 20:38:26.005  INFO ⋮substrate: [Parachain] ✨ Imported #20 (0x4dd0…d81f -> 0x6e85…e2b8)    
2024-04-05 20:38:28.004  INFO ⋮substrate: [Parachain] 🌟 Imported #21 (0x6e85…e2b8 -> 0xad53…2a97)    
2024-04-05 20:38:30.004  INFO ⋮substrate: [Parachain] 🌟 Imported #22 (0xad53…2a97 -> 0xa874…890f)    
```

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Apr 9, 2024
@skunert @bkchr @dharjeezy
Add best block indicator to informant message + print parent block on…
e51eb22 
… import message (paritytech#4021)

Sometimes you need to debug some issues just by the logs and reconstruct
what happened.
In these scenarios it would be nice to know if a block was imported as
best block, and what it parent was.
So here I propose to change the output of the informant to this:

```
2024-04-05 20:38:22.004  INFO ⋮substrate: [Parachain] ✨ Imported paritytech#18 (0xe7b3…4555 -> 0xbd6f…ced7)    
2024-04-05 20:38:24.005  INFO ⋮substrate: [Parachain] ✨ Imported paritytech#19 (0xbd6f…ced7 -> 0x4dd0…d81f)    
2024-04-05 20:38:24.011  INFO ⋮substrate: [jobless-children-5352] 🌟 Imported paritytech#42 (0xed2e…27fc -> 0x718f…f30e)    
2024-04-05 20:38:26.005  INFO ⋮substrate: [Parachain] ✨ Imported paritytech#20 (0x4dd0…d81f -> 0x6e85…e2b8)    
2024-04-05 20:38:28.004  INFO ⋮substrate: [Parachain] 🌟 Imported paritytech#21 (0x6e85…e2b8 -> 0xad53…2a97)    
2024-04-05 20:38:30.004  INFO ⋮substrate: [Parachain] 🌟 Imported paritytech#22 (0xad53…2a97 -> 0xa874…890f)    
```

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
liuchengxu added a commit to subcoin-project/polkadot-sdk that referenced this issue Sep 20, 2024
@liuchengxu
Remove untagged docker versions (paritytech#20)
07c00eb 
* Remove untagged docker versions

* Do not run docker on PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I4-refactor Code needs refactoring.
Projects
SDK Node
Status: backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koute @the-right-joyce