Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVF worker: add security restrictions to child job process with no exceptions #2164

Open
mrcnski opened this issue Nov 5, 2023 · 0 comments
Open

PVF worker: add security restrictions to child job process with no exceptions #2164

mrcnski opened this issue Nov 5, 2023 · 0 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T0-node This PR/Issue is related to the topic “node”.

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Nov 5, 2023

In #1685 we are adding new job processes, forked from the workers, that perform the jobs. The worker's already taken care of reading what it needs from the socket and filesystem, so we can further lock down the job process with no exceptions, if it doesn't hurt performance to do so.

Related

Follow-up to #1685.
@mrcnski mrcnski added T0-node This PR/Issue is related to the topic “node”. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. labels Nov 5, 2023
@mrcnski mrcnski mentioned this issue Nov 9, 2023
Merged
bkontur pushed a commit that referenced this issue May 10, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
3553587 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 14, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
9c49104 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 15, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
f681cfd 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 15, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
3d48cb4 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 15, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
6262c62 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 16, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
f75ca9f 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 17, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
7bd9538 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 17, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
f377cd4 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
svyatonik added a commit that referenced this issue May 17, 2024
@svyatonik
Revive new client and fix relay-halt issue (#2161)
3a7425b 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 20, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
401402e 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 21, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
b73ffa6 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 22, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
7faaeca 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur pushed a commit that referenced this issue May 23, 2024
@svyatonik @bkontur
Revive new client and fix relay-halt issue (#2161)
29fae91 
* Revert "Revert new client (#2153)"

This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de.

* add comment re cache to CachingClient (#2162)

* do not wait for reader when sending items (#2163)

* Use unsync cache + async-aware sync primitives (#2164)

* use unsync cache + async-aware sync primitives

* clippy

* trigger CI

* Revert "trigger CI"

This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T0-node This PR/Issue is related to the topic “node”.
Projects
parachains team board
Status: Backlog
PVF Security Hardening
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrcnski