Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some log messages print with color unconditionally #2795

Closed
2 tasks done
nazar-pc opened this issue Dec 22, 2023 · 0 comments · Fixed by #3009
Closed
2 tasks done

Some log messages print with color unconditionally #2795

nazar-pc opened this issue Dec 22, 2023 · 0 comments · Fixed by #3009
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@nazar-pc
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

Reorg message is the first one:

Ok(ref ancestor) if ancestor.hash != *last_hash => info!(
"♻️ Reorg on #{},{} to #{},{}, common ancestor #{},{}",
Colour::Red.bold().paint(format!("{}", last_num)),
last_hash,
Colour::Green.bold().paint(format!("{}", n.header.number())),
n.hash,
Colour::White.bold().paint(format!("{}", ancestor.number)),
ancestor.hash,
),

Block import is second:

info!(
target: "substrate",
"✨ Imported #{} ({})",
Colour::White.bold().paint(format!("{}", n.header.number())),
n.hash,
);

There might be more, didn't check, but in most places color preference is taken into account.

Steps to reproduce

No response

@nazar-pc nazar-pc added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Dec 22, 2023
github-merge-queue bot pushed a commit that referenced this issue Jan 22, 2024
Changes `sc-informant` to respect the `--disable-log-color` CLI flag.

Closes: #2795

---------

Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
Changes `sc-informant` to respect the `--disable-log-color` CLI flag.

Closes: paritytech#2795

---------

Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
bkchr pushed a commit that referenced this issue Apr 10, 2024
* Fix xcm-bridge-hub build

* Move send_message definition to MessagesBridge impl

* Make send_message infallible

* Split `MessagesBridge` into 2 phases

Split `MessagesBridge` into 2 phases:
- message validation
- message sending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant