Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] build-runtimes-polkavm job doesn't work #3352

Closed
alvicsam opened this issue Feb 16, 2024 · 4 comments · Fixed by #3363
Closed

[ci] build-runtimes-polkavm job doesn't work #3352

alvicsam opened this issue Feb 16, 2024 · 4 comments · Fixed by #3363

Comments

@alvicsam
Copy link
Contributor

alvicsam commented Feb 16, 2024 •
edited
Loading

The job is broken for a few weeks. Should we disable it until it's fixed?

cc @koute @paritytech/ci
@koute
Copy link
Contributor

koute commented Feb 16, 2024

Unless I screwed/misunderstood something up this job was working when I merged it in #3209.

No; let's not disable it. I'll fix it.

While we're at it, do you know why this job doesn't show up on GitHub in the checks list above the "Add a comment"? Wouldn't this make possible to merge PRs which break the job? How can I make it show up?

@alvicsam
Copy link
Contributor Author

Hm, it's interesting. It seems that it runs only on master branch. I'll also take a look.

@alvicsam alvicsam mentioned this issue Feb 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 16, 2024
@alvicsam
[ci] allow fail build-runtimes-polkavm job (#3354)
ad68a05 
PR allows `build-runtimes-polkavm` to fail. Also added DAG to run the
job immediately.

cc paritytech/ci_cd#945
cc #3352
@alvicsam
Copy link
Contributor Author

@koute this PR is now merged and I can see the job in PR pipeline. As soon as you fix it we can mark it as Required in GitHub.

@koute koute mentioned this issue Feb 16, 2024
Merged
@koute
Copy link
Contributor

koute commented Feb 16, 2024

@alvicsam Okay, thanks for the help!

PR with a fix is up: #3363

github-merge-queue bot pushed a commit that referenced this issue Feb 18, 2024
@koute
Make sp-keystore no_std-compatible and fix the `build-runtimes-po…
b179b83 
…lkavm` CI job (#3363)

Fixes #3352
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@koute
Make sp-keystore no_std-compatible and fix the `build-runtimes-po…
98a95b7 
…lkavm` CI job (paritytech#3363)

Fixes paritytech#3352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sp-keystore no_std-compatible and fix the build-runtimes-polkavm CI job koute/polkadot-sdk
2 participants
@koute @alvicsam