-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRDoc crate semver #3984
Comments
#3817 was tagged as |
I mean it is not very important to appear in the release notes. However, the |
We dont yet have CI checks that assert that the Prdoc bumps are correct. |
So, @ggwpez we don't yet need to have the correct bumps in the prdoc yet? Any idea when CI etc tooling will be ready? |
Yea, looks like we were not ready for it yet. Reverted here #3987
No. I think @Morganamilo is working on an extension for the parity-publish to detect breaking changes though. |
Hope it fits : #3995 |
Maybe create a single co-authored PR instead of a bunch of one-liners? |
We dont need it for this Release, its causing too much noise now to ping dozens of ppl. Sorry about this. |
Properly account for paritytech#3302, cc paritytech#3984.
So we can properly version bump with the next release we need to know what kind of changes were made to these crates. Can authors of the following PRs update the PRdoc to specify
patch
,minor
ormajor
. See example here:polkadot-sdk/prdoc/pr_2119.prdoc
Line 10 in 9d052b7
@eskimor @dharjeezy @ordian @k-gunjan @muraca @PraetorP @s0me0ne-unkn0wn @JuaniRios @asiniscalchi @ermalkaleci @bkchr
pallet::getter
usage from cumulus pallets #3471experimental
feature #3654mod apis
#3817The text was updated successfully, but these errors were encountered: