Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move StakingLedger struct definition and implementation #402

Open
1 task
gpestana opened this issue Aug 10, 2023 · 2 comments
Open
1 task

Move StakingLedger struct definition and implementation #402

gpestana opened this issue Aug 10, 2023 · 2 comments
Assignees
@gpestana
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Comments

@gpestana
Copy link
Contributor

gpestana commented Aug 10, 2023 •
edited
Loading

Follow up from #1484 (already merged).

The #1484 has implemented and refactored out some of the code from the StakingLedger into its own module (/src/ledger.rs). In order to keep the PR 1484 clean and with sane diffs, we kept half of the staking ledger related code in src/lib.rs. This issue consists of refactoring the code so that the StakingLedger definition and all impls are in the ledger module.

  • Move the StakingLedger definition and implementation into /staking/src/lib.rs.
@gpestana gpestana self-assigned this Aug 10, 2023
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@gpestana gpestana mentioned this issue Jan 28, 2024
Closed
@gpestana gpestana added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Feb 19, 2024
@joshua-fink
Copy link

Hi, how can I get involved? Looking for a cool open-source project to join :)

@omadoyeabraham
Copy link

@gpestana I would like to work on this, can I proceed?

jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Prometheus options in Substrate relay (paritytech#402)
ddeb59d
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpestana gpestana

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
(Nominated) Proof of Stake
Status: 📕 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

staking: Moves all StakingLedger logic to staking/src/ledger.rs paritytech/polkadot-sdk
4 participants
@gpestana @omadoyeabraham @joshua-fink @the-right-joyce