Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transfer_all Call in Assets Pallet #4517

Closed
joepetrowski opened this issue May 19, 2024 · 1 comment · Fixed by #4527
Closed

transfer_all Call in Assets Pallet #4517

joepetrowski opened this issue May 19, 2024 · 1 comment · Fixed by #4527
Assignees
@pandres95
Labels
I5-enhancement An additional feature request. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@joepetrowski
Copy link
Contributor

With the ability to pay fees in assets, there is demand from some users to be able to "pay fees with and transfer all", completely killing the balance of the asset on the account. We should add this transfer_all call to the Assets pallet to make this easier without needing to calculate fees/exchange rates to determine transferrable amount.

@pandres95 ?
@joepetrowski joepetrowski added the T2-pallets This PR/Issue is related to a particular pallet. label May 19, 2024
@pandres95
Copy link
Contributor

I'll take it.😁

@bkchr bkchr added the I5-enhancement An additional feature request. label May 19, 2024
@liamaharon liamaharon moved this to In Development in Asset Improvement Board May 20, 2024
@pandres95 pandres95 mentioned this issue May 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 7, 2024
@pandres95 @joepetrowski
[Assets] Call implementation for transfer_all (#4527)
6db2038 
Closes #4517

Polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Development to Shipped in Asset Improvement Board Aug 7, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Aug 7, 2024
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Aug 28, 2024
@pandres95 @joepetrowski @dharjeezy
[Assets] Call implementation for transfer_all (paritytech#4527)
356472c 
Closes paritytech#4517

Polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR

---------

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pandres95 pandres95

Labels
I5-enhancement An additional feature request. T2-pallets This PR/Issue is related to a particular pallet.
Projects
Asset Improvement Board
Status: Shipped
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Assets] Call implementation for transfer_all pandres95/polkadot-sdk
3 participants
@pandres95 @bkchr @joepetrowski