Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approval voting: fix flaky approval voting benchmark #5081

Closed
sandreim opened this issue Jul 19, 2024 · 0 comments · Fixed by #5115
Closed

approval voting: fix flaky approval voting benchmark #5081

sandreim opened this issue Jul 19, 2024 · 0 comments · Fixed by #5115
Assignees
@AndreiEres
Labels
T10-tests This PR/Issue is related to tests.

Comments

@sandreim
Copy link
Contributor 

The resource `Sent to peers` is expected to be equal to 63547.033 with a precision 0.001, but the current value is 63792.68000000001 (0.003865593536050762)
The resource `approval-distribution` is expected to be equal to 7.4075 with a precision 0.1, but the current value is 6.036226178810057 (0.18511965186499402)

https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6741777
@sandreim sandreim added the T10-tests This PR/Issue is related to tests. label Jul 19, 2024
@AndreiEres AndreiEres mentioned this issue Jul 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 23, 2024
@AndreiEres
[subsystem-bench] Adjust approval-voting-regression-bench (#5115)
2bd187f 
Fixes #5081

After last changes in approval subsystem and their benchmarks base
values need to be updated
@github-project-automation github-project-automation bot moved this from Backlog to Completed in parachains team board Jul 23, 2024
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@AndreiEres @TarekkMA
[subsystem-bench] Adjust approval-voting-regression-bench (paritytech…
2f18d45 
…#5115)

Fixes paritytech#5081

After last changes in approval subsystem and their benchmarks base
values need to be updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiEres AndreiEres

Labels
T10-tests This PR/Issue is related to tests.
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[subsystem-bench] Adjust approval-voting-regression-bench paritytech/polkadot-sdk
2 participants
@AndreiEres @sandreim