Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet macro: Tasks doesn't support instantiable pallets. #5185

Closed
gui1117 opened this issue Jul 30, 2024 · 2 comments · Fixed by #5194
Closed

pallet macro: Tasks doesn't support instantiable pallets. #5185

gui1117 opened this issue Jul 30, 2024 · 2 comments · Fixed by #5194
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@gui1117
Copy link
Contributor

gui1117 commented Jul 30, 2024 •
edited
Loading

The code only handles non instantiable pallets like this:

				impl<T: Config> core::fmt::Debug for #ident<#type_use_generics> {
					fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
						f.debug_struct(stringify!(#ident)).field("value", self).finish()
					}
				}
@gui1117 gui1117 added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Jul 30, 2024
@ggwpez
Copy link
Member

ggwpez commented Jul 30, 2024

cc @gupnik

@gui1117
Copy link
Contributor Author

gui1117 commented Jul 30, 2024

I have an initial implementation here: https://github.com/paritytech/polkadot-sdk/compare/master...gui1117:gui-tasks-instantiable-pallets?expand=1

@gui1117 gui1117 mentioned this issue Jul 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2024
@gui1117 @ggwpez @bkchr
pallet macro: Support instantiable pallets in tasks (#5194)
68af85e 
Fix #5185

also implement handling of attr in expansion in construct-runtime

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 25, 2024
@gui1117 @ggwpez
@bkchr @mordamax
pallet macro: Support instantiable pallets in tasks (paritytech#5194)
38bcb5d 
Fix paritytech#5185

also implement handling of attr in expansion in construct-runtime

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 25, 2024
@gui1117 @ggwpez
@bkchr @mordamax
pallet macro: Support instantiable pallets in tasks (paritytech#5194)
496d560 
Fix paritytech#5185

also implement handling of attr in expansion in construct-runtime

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 25, 2024
@gui1117 @ggwpez
@bkchr @mordamax
pallet macro: Support instantiable pallets in tasks (paritytech#5194)
04eab7d 
Fix paritytech#5185

also implement handling of attr in expansion in construct-runtime

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 25, 2024
@gui1117 @ggwpez
@bkchr @mordamax
pallet macro: Support instantiable pallets in tasks (paritytech#5194)
03db029 
Fix paritytech#5185

also implement handling of attr in expansion in construct-runtime

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 25, 2024
@gui1117 @ggwpez
@bkchr @mordamax
pallet macro: Support instantiable pallets in tasks (paritytech#5194)
defd401 
Fix paritytech#5185

also implement handling of attr in expansion in construct-runtime

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@gui1117 @ggwpez
@bkchr @mordamax
pallet macro: Support instantiable pallets in tasks (paritytech#5194)
32ed0ce 
Fix paritytech#5185

also implement handling of attr in expansion in construct-runtime

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@gui1117 @ggwpez
@bkchr @mordamax
pallet macro: Support instantiable pallets in tasks (paritytech#5194)
1cb818b 
Fix paritytech#5185

also implement handling of attr in expansion in construct-runtime

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pallet macro: Support instantiable pallets in tasks gui1117/polkadot-sdk
2 participants
@ggwpez @gui1117