Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong spending limit comments in Kusama governance config #753

Open
brenzi opened this issue Nov 15, 2022 · 3 comments · May be fixed by paritytech/polkadot#6310
Open

wrong spending limit comments in Kusama governance config #753

brenzi opened this issue Nov 15, 2022 · 3 comments · May be fixed by paritytech/polkadot#6310

Comments

@brenzi
Copy link
Contributor

brenzi commented Nov 15, 2022 •
edited
Loading

These comments seem to be outdated:
https://github.com/paritytech/polkadot/blob/b984c40cc5217eda68f630e329320dc26578a0bc/runtime/kusama/src/governance/origins.rs#L51-L60

As these lines suggest other limits (though not very far apart):
https://github.com/paritytech/polkadot/blob/b984c40cc5217eda68f630e329320dc26578a0bc/runtime/kusama/src/governance/origins.rs#L173-L175

As 1 GRAND = 3.33 KSM
https://github.com/paritytech/polkadot/blob/3fbf6e4698e6abcc621095c8bbeefe37f70568be/runtime/kusama/constants/src/lib.rs#L26-L32

the limits seem to be
SmallSpender: 10 GRAND = 33.3 KSM
MediumSpender: 100 GRAND = 333 KSM
BigSpender: 1000 GRAND = 3.33 kKSM
@bkchr
Copy link
Member

bkchr commented Nov 15, 2022

If the comments are wrong, could you create a pr?

@brenzi
Copy link
Contributor Author

brenzi commented Nov 15, 2022

Will do. Wanted to know if I miss something

@bkchr
Copy link
Member

bkchr commented Nov 15, 2022

CC @shawntabrizi

@brenzi brenzi linked a pull request Nov 18, 2022 that will close this issue
Open
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@doubledup
Remove incentivized channel and apps (paritytech#762)
345c63d 
* Remove apps & incentivized channel from parachain (paritytech#753)

* Remove apps & incentivized channel from parachain

* Fix formatting

* Remove incentivized channel & channel ID from relayer (paritytech#756)

* Remove incentivized channel from relayer

Will regenerate the bindings in contracts/ in the Solidity PR.

Still TODO:
- Remove mapping in:
    - relayer/cmd/fetch_messages.go
    - relayer/relays/ethereum/ethereum-listener.go
- Remove redundant imports of github.com/ethereum/go-ethereum/core/types
- Remove channel ID in relayer/relays/parachain/query_events.go
- Remove other occurrences of channelId:
rg -i channelid | sed -r 's/([^:]*):.*/\1/' | uniq | rg -v ^contracts/
- Replace Events with BasicChannelEvent in
  relayer/relays/parachain/query_events.go
- Remove unused relays/parachain/storage_key.go

* Remove address-method mapping for basic channel

* Remove redundant import

* Remove unused module storage_key

* Remove channelID

* Replace Events struct with BasicChannelEvent

* Remove incentivized channel, apps, channel ID & sundry from contracts (paritytech#757)

* Remove incentivized channel

* Remove deprecated prettier option

Deprecated in prettier-plugin-solidity 1.0.0:
NomicFoundation/hardhat-vscode#367 (comment)

The comment above indicates that solhint might have a rule for this, but
it doesn't look like there is one yet:
https://protofire.github.io/solhint/

* Remove apps

* Remove channel id

* Remove unused OpaqueProof

* Regenerate contract bindings

* Replace necessary contracts

* Fix generated contract bindings

Remove incentivized channel bindings & keep generating OpaqueProof.

* Move log & mining settings to Hardhat config

* Remove other references to apps & custom token

* Remove incentivized channel and apps from test & cleanup  (paritytech#759)

* Remove app and incentivized channel from tests

This also removes all existing tests, since they all depend on the apps.

* Remove channelID

* Remove some remaining references

Still need to decide on the docs/ and core/packages/api/ directories.

* Remove asset-registry pallet

Not removing the assets pallet yet, as it's still used by the XCM
pallet.

* Reorder params to match other runtimes

Makes diffs between the runtimes cleaner.

* Remove detect-fork script

* Remove helper code in src/

* Keep src/ directory

* Convert MessageId to struct
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@sorpaas
Limit number of iterations in genesis nonce building (paritytech#753)
fed5e0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix spending limits comments of gov2 origins brenzi/polkadot
2 participants
@bkchr @brenzi