Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usages of relay_dispatch_queue_size #755

Open
gavofyork opened this issue Nov 14, 2022 · 5 comments
Open

Remove all usages of relay_dispatch_queue_size #755

gavofyork opened this issue Nov 14, 2022 · 5 comments
Labels
I4-refactor Code needs refactoring.

Comments

@gavofyork
Copy link
Member

gavofyork commented Nov 14, 2022

Currently, a well-known key on the Relay-chain, relay_dispatch_queue_size, is used by parachains/cumulus to determine what messages (how many, how big) may be pushed up through UMP. This is a bit silly as it needs knowledge of the configuration items and certain assumptions on how the chain operations before it is useful.

Instead, there is now a new well-known key relay_dispatch_queue_remaining_capacity which retains the available amount of space and slots for UMP messages. All usages of the former should be removed in favour of this. This should lead to some simplification.

Relies on paritytech/polkadot#6271 .

@tifecool
Copy link

Down to carry this out as soon as paritytech/polkadot#6271 is complete.

@daredevil3435
Copy link

Hey, I want to strt contributing to polkadot.What are the prerequisites for that?

@bkchr
Copy link
Member

bkchr commented Jan 1, 2023

@daredevil3435 as you see the prerequisity is not done yet.

@daredevil3435
Copy link

@bkchr oh okay gotcha

@bkchr
Copy link
Member

bkchr commented May 20, 2023

The migration to relay_dispatch_queue_remaining_capacity will not be that easy. We first need to enact paritytech/polkadot#6271 on chain to have the new key available. Then we will need to wait for all parachains to have migrated to relay_dispatch_queue_remaining_capacity before we can remove relay_dispatch_queue_size.

With paritytech/cumulus#2608 Parachains will first try to load relay_dispatch_queue_remaining_capacity from the relay chain proof, before they fall back to relay_dispatch_queue_size. However, this will require runtime upgrades on the Parachains the storage proof read inside the runtime.

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.81 to 1.0.82.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.81...v1.0.82)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
bkchr pushed a commit that referenced this issue Apr 10, 2024
* Use no-op ancestry checker

* Check that current header height is greater than last finalized

* Ensure that incoming headers are strictly greater than last finalized

* Ensure that header numbers always increase in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I4-refactor Code needs refactoring.
Projects
Status: Backlog
Status: To do
Development

No branches or pull requests

6 participants