Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVF: Take back a stolen right #1207

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Conversation

mrcnski
Copy link
Contributor

@mrcnski mrcnski commented Aug 28, 2023

After a recent worker revolt, the workers managed to gain a small amount of freedom from the landowner host. But after the failed proletariat revolution, there were mass migrations and we ended up in a new repo. The capitalists took advantage of the confusion to secretly take away a workers' right. We must undo this before it goes too far.

After a recent [worker
revolt](paritytech/polkadot#7538), they managed to gain
a small amount of freedom from the landowner host. But after the failed
[proletariat revolution](paritytech/polkadot#7570),
there were mass migrations and we ended up in a new repo. The capitalists took
advantage of the confusion to secretly take away a workers' right. We must undo
this before it goes too far.
@mrcnski mrcnski self-assigned this Aug 28, 2023
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! I completely forgot about that dependency loop through sp-tracing 🤦‍♂️

@mrcnski
Copy link
Contributor Author

mrcnski commented Aug 29, 2023

dependency loop through sp-tracing 🤦‍♂️

Can you explain? I don't remember the full context of the change, just adding back stuff that was stolen during the migration.

@sandreim
Copy link
Contributor

I like the PR description style 🥇

@mrcnski mrcnski added T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Aug 29, 2023
Workers always should have tracing, including in production, it should not be
gated behind the `test-utils` feature.

Added a note to eventually remove it with a link to the issue.
…ight' into mrcnski/pvf-take-back-a-stolen-right
@mrcnski
Copy link
Contributor Author

mrcnski commented Aug 31, 2023

bot merge

@command-bot
Copy link

command-bot bot commented Aug 31, 2023

@mrcnski Unknown command "merge". Refer to help docs and/or source code.

@mrcnski mrcnski merged commit 7cef7cd into master Aug 31, 2023
5 checks passed
@mrcnski mrcnski deleted the mrcnski/pvf-take-back-a-stolen-right branch August 31, 2023 08:48
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants