Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ed25519-dalek to v2 #1446

Merged
merged 7 commits into from
Sep 8, 2023
Merged

Update ed25519-dalek to v2 #1446

merged 7 commits into from
Sep 8, 2023

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Sep 7, 2023

This PR removes the dependency on ed25519-dalek v1.

Seel also https://github.com/paritytech/polkadot-sdk/security/dependabot/3

cc @bkontur

@chevdor chevdor added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. labels Sep 7, 2023
@chevdor chevdor requested a review from bkontur September 7, 2023 10:34
@paritytech-ci paritytech-ci requested a review from a team September 7, 2023 10:36
@chevdor
Copy link
Contributor Author

chevdor commented Sep 7, 2023

@bkontur I want to make sure you saw that one pass by.
Can we merge it ?

@chevdor chevdor merged commit 92d7751 into master Sep 8, 2023
@chevdor chevdor deleted the wk-230906-update-ed25519-dalek branch September 8, 2023 10:14
Ank4n pushed a commit that referenced this pull request Sep 8, 2023
* Update to ed25519-dalek v2
* Update Cargo.lock
* Remove default features
* Update cumulus/bridges/primitives/test-utils/src/keyring.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* Update to ed25519-dalek v2
* Update Cargo.lock
* Remove default features
* Update cumulus/bridges/primitives/test-utils/src/keyring.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
* Update to ed25519-dalek v2
* Update Cargo.lock
* Remove default features
* Update cumulus/bridges/primitives/test-utils/src/keyring.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
bkchr pushed a commit that referenced this pull request Apr 10, 2024
…1446)

* BridgeRejectObsoleteMessages

* add obsolete confirmations verification to the BridgeRejectObsoleteMessages

* move tests where they belong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants