Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update contributing guide and ui-tests scripts #1668

Merged
merged 12 commits into from
Sep 22, 2023
Merged

update contributing guide and ui-tests scripts #1668

merged 12 commits into from
Sep 22, 2023

Conversation

mordamax
Copy link
Contributor

  • Updated ./docs/CONTRIBUTION.md to clarify how to use command bot and update ui-tests locally or in PR
  • Moved update-ui-tests.sh to a root of project to run them along for substrate and polkadot together

@mordamax mordamax requested a review from a team as a code owner September 21, 2023 17:06
@paritytech-ci paritytech-ci requested a review from a team September 21, 2023 17:08
@mordamax mordamax added R0-silent Changes should not be mentioned in any release notes T11-documentation This PR/Issue is related to documentation. labels Sep 21, 2023
altaua
altaua reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@altaua altaua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we keep all the logic in a single global script and avoid the extra scripts in substrate/ and polkadot/? Less indirection would make this more readable imo.

substrate/.maintain/update-rust-stable.sh Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team September 21, 2023 17:52
@mordamax
Copy link
Contributor Author

bot update-ui -v PIPELINE_SCRIPTS_REF=mak-cleanup-update-ui-tests

@mordamax
Copy link
Contributor Author

mordamax commented Sep 21, 2023 •
edited
Loading

@bkchr cargo test -p orchestra ui failed with
error: package "orchestra" cannot be tested because it requires dev-dependencies and is not a member of the workspace
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3766421
do you know how to fix? or just exclude for now?

@paritytech-ci paritytech-ci requested a review from a team September 22, 2023 06:41
@mordamax
Copy link
Contributor Author

bot clean
bot update-ui latest -v PIPELINE_SCRIPTS_REF=mak-cleanup-update-ui-tests --rust_version=1.70

@bkchr
Copy link
Member

bkchr commented Sep 22, 2023

@bkchr cargo test -p orchestra ui failed with error: package "orchestra" cannot be tested because it requires dev-dependencies and is not a member of the workspace https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3766421 do you know how to fix? or just exclude for now?

Yeah the crate doesn't exist anymore in our repo, so you can just drop the line.

@mordamax
Copy link
Contributor Author

bot clean
bot update-ui -v PIPELINE_SCRIPTS_REF=mak-cleanup-update-ui-tests

@command-bot
Copy link

command-bot bot commented Sep 22, 2023 •
edited
Loading

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3776309 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-eef2b186-6820-4ee7-9c32-7b864664d829 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 22, 2023

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3776309 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3776309/artifacts/download.

@mordamax mordamax requested a review from altaua September 22, 2023 16:36
altaua
altaua approved these changes Sep 22, 2023
View reviewed changes
scripts/update-ui-tests.sh Outdated Show resolved Hide resolved
scripts/update-ui-tests.sh Outdated Show resolved Hide resolved
altaua
altaua reviewed Sep 22, 2023
View reviewed changes
scripts/update-ui-tests.sh Outdated Show resolved Hide resolved
@altaua altaua self-requested a review September 22, 2023 16:49
mordamax and others added 3 commits September 22, 2023 18:29
@mordamax
Update update-ui-tests.sh
00b3b93
@mordamax
Update scripts/update-ui-tests.sh
95b2eff 
Co-authored-by: Mira Ressel <mira@parity.io>
@mordamax
Update scripts/update-ui-tests.sh
3abddc7 
Co-authored-by: Mira Ressel <mira@parity.io>
@mordamax
Copy link
Contributor Author

bot update-ui latest -v PIPELINE_SCRIPTS_REF=mak-cleanup-update-ui-tests --rust_version=1.70

@command-bot
Copy link

command-bot bot commented Sep 22, 2023 •
edited
Loading

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3777200 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.70. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-78c994ef-dbb6-4a6d-8f2d-d440678b4ce5 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 22, 2023

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.70 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3777200 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3777200/artifacts/download.

@mordamax mordamax merged commit 3d9f5e8 into master Sep 22, 2023
8 checks passed
@mordamax mordamax deleted the mak-update-ui branch September 22, 2023 21:48
ordian added a commit that referenced this pull request Sep 27, 2023
@ordian
merge master and resolve conflicts (v8)
6fb4b7f 
* master: (61 commits)
  OpenGov in Westend and Rococo (#1177)
  Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720)
  Migrate polkadot-primitives to v6 (#1543)
  genesis-builder: implemented for all runtimes (#1492)
  `BlockId` removal: `tx-pool` refactor (#1678)
  Bump directories from 4.0.1 to 5.0.1 (#1656)
  Allow debug_assertions in short-benchmarks CI job (#1711)
  chainHead/storage: Fix storage iteration using the query key (#1665)
  Implement more useful traits in `Slot` type (#1595)
  Make downloads in parallel and give more time to complete (#1699)
  Bump actions/checkout from 4.0.0 to 4.1.0 (#1688)
  contracts: Fix incorrect storage alias in mirgration (#1687)
  Fix documentation about justification and `finalized == true` requirement (#1607)
  tweak pallet macro (genesis_config etc) to cater for RA users as well. (#1689)
  Uncoupling pallet-xcm from frame-system's RuntimeCall (#1684)
  Bump aes-gcm from 0.10.2 to 0.10.3 (#1681)
  docs / Update PR template to reflect monorepo (#1674)
  update contributing guide and ui-tests scripts (#1668)
  pallet epm: add `TrimmingStatus` to the mined solution (#1659)
  Update HRMP pallet benchmarking to use benchmarks v2 (#1676)
  ...
@kiltbot kiltbot mentioned this pull request Oct 19, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@mordamax
update contributing guide and ui-tests scripts (paritytech#1668)
879c58e 
- Updated ./docs/CONTRIBUTION.md to clarify how to use command bot and
update ui-tests locally or in PR
- Moved update-ui-tests.sh to a root of project to run them along for
substrate and polkadot together

---------

Co-authored-by: Mira Ressel <mira@parity.io>
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
fix clippy (#1668)
b992677
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altaua altaua altaua approved these changes

@sergejparity sergejparity sergejparity approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T11-documentation This PR/Issue is related to documentation.
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mordamax @bkchr @ggwpez @sergejparity @altaua