-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet vesting / update to use fungible #1760
Conversation
Moment = BlockNumberFor<Self>, | ||
Fungible = Self::Fungible, | ||
>; | ||
type Fungible: fungible::Inspect<Self::AccountId, Balance = Self::Balance> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type Fungible: fungible::Inspect<Self::AccountId, Balance = Self::Balance> | |
type Currency: fungible::Inspect<Self::AccountId, Balance = Self::Balance> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or type NativeToken
, as suggested in #226 (comment)
|
||
/// A vesting schedule over a fungible. This allows a particular fungible to have vesting limits | ||
/// applied to it. | ||
pub trait VestingSchedule<AccountId>: Sized { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a later date Currency
is likely to be removed. At that point it's going to be all alone in the traits::tokens::currency
namespace. Is there a better namespace for it to migrate to or should we leave it where it is for now even though it now takes a Fungible
?
Any update on this? #3951 is almost merged, and if we merge this I think we can finally have vesting of pallet-assets tokens on AssetHub, which would bring a lot of added value to AssetHub |
This updates the vesting pallet to use the new fungible traits rather than the now deprecated
Currency
andReserveCurrency
traits ( paritytech/substrate#12951 ). Partial fix of #226.TODO:
add_locks
in benchmark needs a rethink because RuntimeFreezeReasons isn't a[u8;8]