Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add link checker #1875

Merged
merged 11 commits into from
Oct 16, 2023
Merged

[CI] Add link checker #1875

merged 11 commits into from
Oct 16, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Oct 15, 2023

Adding link checker to the CI (closes #993). It would be nice to have the docs people own this and extend accordingly.
Currently all known-bad links are excluded, but we should one-by-one include those as well until all are fixed.

This check now ensures that 1) no new broken links are introduced into .rs files and 2) that no old links break unnoticed.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Oct 15, 2023
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review October 15, 2023 17:05
@ggwpez ggwpez requested review from a team as code owners October 15, 2023 17:05
@paritytech-ci paritytech-ci requested a review from a team October 16, 2023 07:48
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to cover the prdoc files as well but happy to have the current state as a start already.

.config/lychee.toml Outdated Show resolved Hide resolved
.github/workflows/check-links.yml Show resolved Hide resolved
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez merged commit e0e566b into master Oct 16, 2023
110 checks passed
@ggwpez ggwpez deleted the oty-link-check branch October 16, 2023 12:19
tdimitrov pushed a commit that referenced this pull request Oct 23, 2023
Adding link checker to the CI (closes
#993). It would be nice
to have the docs people own this and extend accordingly.
Currently all known-bad links are excluded, but we should one-by-one
include those as well until all are fixed.

This check now ensures that 1) no new broken links are introduced into
`.rs` files and 2) that no old links break unnoticed.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Add link checker
5 participants