[DO NOT MERGE]: PoC rpc rate limit middleware #2208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
niklasad1
changed the title
|
we have recently implemented rate limiting with Subway https://github.com/AcalaNetwork/subway |
Nice but I think it's worth to provide a custom ResponseFuture not box the futures as it will run for every rpc call and use more memory. When native async trait is thing in rust we could change the middleware in jsonrpsee to be easier to work with. //cc @PierreBesson may be worth to test out subway now :) The govenor crate looks neat. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkontur
pushed a commit
that referenced
this pull request
May 14, 2024
bkontur
pushed a commit
that referenced
this pull request
May 15, 2024
bkontur
pushed a commit
that referenced
this pull request
May 15, 2024
bkontur
pushed a commit
that referenced
this pull request
May 15, 2024
bkontur
pushed a commit
that referenced
this pull request
May 15, 2024
bkontur
pushed a commit
that referenced
this pull request
May 16, 2024
bkontur
pushed a commit
that referenced
this pull request
May 17, 2024
bkontur
pushed a commit
that referenced
this pull request
May 17, 2024
svyatonik
pushed a commit
that referenced
this pull request
May 17, 2024
bkontur
pushed a commit
that referenced
this pull request
May 20, 2024
bkontur
pushed a commit
that referenced
this pull request
May 21, 2024
bkontur
pushed a commit
that referenced
this pull request
May 22, 2024
bkontur
pushed a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
--rpc-rate-limit (calls per min)