Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate-block: Fix TrieCache implementation #2214

Merged
merged 2 commits into from
Nov 8, 2023

Commits on Nov 7, 2023

  1. validate-block: Fix TrieCache implementation

    The trie cache implementation was ignoring the `storage_root` when
    setting up the value cache. The problem with this is that the value
    cache works using `storage_keys` and these keys are not unique across
    different tries. A block can actually have different tries (main trie
    and multiple child tries). This pull request fixes the issue by not
    ignoring the `storage_root` and returning an unique `value_cache` per
    `storage_root`. It also adds a test for the seen bug and improves
    documentation that this doesn't happen again.
    bkchr committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b031fdc View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Fix warning

    bkchr committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    10e6891 View commit details
    Browse the repository at this point in the history