Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flag to enable v2 assignments #2444

Merged
merged 14 commits into from
Dec 11, 2023
Merged

Add feature flag to enable v2 assignments #2444

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
da6fd18
Add feature flag to enable v2 assignments
alexggh Nov 22, 2023
7981d4b
Fix tests
alexggh Nov 22, 2023
ae47dca
Make sure node features is always checked
alexggh Nov 22, 2023
629fffa
Merge remote-tracking branch 'origin/master' into feature_enablement
alexggh Dec 5, 2023
29a51e8
Add unittest for features enablement
alexggh Dec 5, 2023
0e45f6a
Address review feedback
alexggh Dec 5, 2023
e0463f3
Merge remote-tracking branch 'origin/master' into feature_enablement
alexggh Dec 8, 2023
3404f2d
Merge remote-tracking branch 'origin/master' into feature_enablement
alexggh Dec 8, 2023
59fcfc8
Merge branch 'master' into alexaggh/feature_enablement
alexggh Dec 8, 2023
7669d60
Fix tests
alexggh Dec 8, 2023
b0664f4
Merge branch 'master' into alexaggh/feature_enablement
alexggh Dec 8, 2023
5be2517
Empty commit to re-trigger ci
alexggh Dec 8, 2023
dc95bed
Merge branch 'master' into alexaggh/feature_enablement
alexggh Dec 11, 2023
cb09341
Merge branch 'master' into alexaggh/feature_enablement
alexggh Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion polkadot/node/core/approval-voting/src/criteria.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ pub(crate) trait AssignmentCriteria {
relay_vrf_story: RelayVRFStory,
config: &Config,
leaving_cores: Vec<(CandidateHash, CoreIndex, GroupIndex)>,
enable_v2_assignments: bool,
) -> HashMap<CoreIndex, OurAssignment>;

fn check_assignment_cert(
Expand All @@ -282,8 +283,9 @@ impl AssignmentCriteria for RealAssignmentCriteria {
relay_vrf_story: RelayVRFStory,
config: &Config,
leaving_cores: Vec<(CandidateHash, CoreIndex, GroupIndex)>,
enable_v2_assignments: bool,
) -> HashMap<CoreIndex, OurAssignment> {
compute_assignments(keystore, relay_vrf_story, config, leaving_cores, false)
compute_assignments(keystore, relay_vrf_story, config, leaving_cores, enable_v2_assignments)
}

fn check_assignment_cert(
Expand Down
Loading
Loading