Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts: make benchmark dependencies optional in std feature #2576

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Contracts: make benchmark dependencies optional in std feature #2576

merged 3 commits into from
Dec 1, 2023

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Dec 1, 2023 •
edited
Loading

wasm-instrument and rand are optional and only used in benchmarking, so should not be pulled in by default as part of the std feature.

@ascjones ascjones added the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Dec 1, 2023
@ascjones ascjones requested a review from athei as a code owner December 1, 2023 10:22
@ascjones ascjones requested a review from a team December 1, 2023 10:22
@ascjones ascjones changed the title Remove wasm-instrument from default std feature Contracts: remove wasm-instrument from default std feature Dec 1, 2023
@ascjones ascjones added the R0-silent Changes should not be mentioned in any release notes label Dec 1, 2023
@ascjones ascjones changed the title Contracts: remove wasm-instrument from default std feature Contracts: make wasm-instrument optional in std feature Dec 1, 2023
@ascjones ascjones changed the title Contracts: make wasm-instrument optional in std feature Contracts: make benchmark dependencies optional in std feature Dec 1, 2023
@ascjones ascjones enabled auto-merge (squash) December 1, 2023 11:18
@ascjones ascjones merged commit dfd7b15 into master Dec 1, 2023
116 of 117 checks passed
@ascjones ascjones deleted the aj/contracts-wasm-instrument branch December 1, 2023 11:19
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@ascjones
Contracts: make benchmark dependencies optional in std feature (par…
7fcd0ca 
…itytech#2576)

`wasm-instrument` and `rand` are optional and only used in benchmarking,
so should not be pulled in by default as part of the `std` feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xermicus xermicus xermicus approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascjones @athei @xermicus