Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix node-bench-regression-guard job #2732

Merged
merged 4 commits into from
Dec 18, 2023
Merged

[ci] Fix node-bench-regression-guard job #2732

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee71f17
[DNM][ci] Debug node-regresion-gueard job
alvicsam Dec 18, 2023
5a793cd
add check
alvicsam Dec 18, 2023
4796543
specify GIT_STRATEGY explicitly
alvicsam Dec 18, 2023
be1953f
git_clone -> git_depth
alvicsam Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .gitlab/pipeline/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,15 @@ node-bench-regression-guard:
artifacts: true
variables:
CI_IMAGE: "paritytech/node-bench-regression-guard:latest"
# current git limit is 20, set to 100 to avoid failures (gitlab removes old artifacts)
GIT_LIMIT: 100
GIT_STRATEGY: fetch
before_script: [""]
script:
- if [ $(ls -la artifacts/benches/ | grep master | wc -l) == 0 ]; then
echo "Couldn't find master artifacts, consider increasing GIT_LIMIT variable";
exit 1;
fi
- echo "------- IMPORTANT -------"
- echo "node-bench-regression-guard depends on the results of a cargo-check-benches job"
- echo "In case of this job failure, check your pipeline's cargo-check-benches"
Expand Down Expand Up @@ -520,6 +527,6 @@ test-syscalls:
- ./list-syscalls.rb ../../../target/x86_64-unknown-linux-musl/production/polkadot-prepare-worker --only-used-syscalls | diff -u prepare-worker-syscalls -
after_script:
- if [[ "$CI_JOB_STATUS" == "failed" ]]; then
printf "The x86_64 syscalls used by the worker binaries have changed. Please review if this is expected and update polkadot/scripts/list-syscalls/*-worker-syscalls as needed.\n";
printf "The x86_64 syscalls used by the worker binaries have changed. Please review if this is expected and update polkadot/scripts/list-syscalls/*-worker-syscalls as needed.\n";
fi
allow_failure: false # this rarely triggers in practice