Introduce BlockWeightsForAsyncBacking and MAXIMUM_BLOCK_WEIGHT_FOR_ASYNC_BACKING to bridges primitives
#2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ASYNC_BACKING` to bridges primitives
mrcnski
reviewed
Jan 17, 2024
bkontur
commented
Jan 17, 2024
bkontur
commented
Jan 17, 2024
bkontur
commented
Jan 17, 2024
svyatonik
approved these changes
Jan 18, 2024
svyatonik
added
R0-silent
acatangiu
approved these changes
Jan 18, 2024
bkchr
reviewed
Jan 18, 2024
| /// We allow for 2 seconds of compute with a 6 second average block. | ||
| /// | ||
| /// This is a copy-paste of system parachain runtimes switched to async backing (https://github.com/paritytech/polkadot-sdk/pull/2949). | ||
| const MAXIMUM_BLOCK_WEIGHT_FOR_ASYNC_BACKING: Weight = Weight::from_parts( |
There was a problem hiding this comment.
This makes no sense? Either the runtime is running using async backing or not. This means you should update BlockWeights directly.
There was a problem hiding this comment.
Runtime's BlockWeights are updated directly in that #2949.
Here we try to keep bridges primitives in sync.
Bridges repo is partially migrated to the polkadot-sdk, the relayer part is missing, and we use these primitives for relayer code also (I will double-check if it is really needed now), that's the reason we have these "duplicite" copies. From time to time, we sync/backport bridges repo with polkadot-sdk.
mrcnski
merged commit 42f5d1b
into
mrcnski/enable-async-backing-on-testnet-system-chains
134 of 138 checks passed
mrcnski
deleted the
bko-mrcnski/enable-async-backing-on-testnet-system-chains
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4943591