approval-distribution: Update topology if authorities are discovered later #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
eskimor
reviewed
Jan 18, 2024
| .filter(|peer| ids.contains(&peer.discovery_id)) | ||
| { | ||
| peer.peer_ids.push(peer_id); | ||
| self.peer_ids.insert(peer_id); |
There was a problem hiding this comment.
If it is already in peer_ids, why do we insert it?
There was a problem hiding this comment.
Yeah, that's why tests it is on the todo list, fixed.
I was looking more about what you think of the approach does it seem reasonable to you ?
There was a problem hiding this comment.
Seems reasonable at first sight, yes.
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
|
Tested on versi and this PR has the expected behaviour, at node restart we don't have any authority-peer_id mapping in the case, but at next active leaves updates all Peer ids are correctly detected. |
alexggh
added
the
T8-polkadot
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
sandreim
approved these changes
Jan 25, 2024
alexggh
added a commit
that referenced
this pull request
Feb 8, 2024
…overed later (#2981) The previous fix was actually incomplete because we update the authorties only on the situation where we decided to reconnect because we had a low connectivity issue. Now the problem is that update_authority_ids use the list of connected peers, so on restart that does contain anything, so calling immediately after issue_connection_request won't detect all authorties, so we need to also check every block as the comment said, but that did not match the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2138.
Especially on restart AuthorithyDiscovery cache is not populated so we create an invalid topology and messages won't be routed correctly for the entire session. This PR proposes to try to fix this by updating the topology as soon as we now the Authority/PeerId mapping, that should impact the situation dramatically.
This issue was hit yesterday, on Westend and resulted in stalling the finality.
TODO