Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc-v2/tx: Rename transaction to transactionWatch #3040

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Jan 24, 2024

This PR backports the changes from paritytech/json-rpc-interface-spec#107.

The transaction class becomes transactionWatch, and the other functionality remains the same.

// cc @paritytech/subxt-team

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Jan 24, 2024
@lexnv lexnv self-assigned this Jan 24, 2024
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick turnaround :)

Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Any plans to add these new methods transaction_unstable_broadcast and transaction_unstable_stop as well or file an issue for it?

@lexnv
Copy link
Contributor Author

lexnv commented Jan 24, 2024

Yep yep, I'm currently looking into adding the broadcast methods, I've already created an issue for it 🙏

I felt this PR is quite small and went ahead without an issue :D

The overarching V2 implementation can be tracked at:

@lexnv lexnv added this pull request to the merge queue Jan 25, 2024
Merged via the queue into master with commit 5c79ed3 Jan 25, 2024
125 of 126 checks passed
@lexnv lexnv deleted the lexnv/rename-tx branch January 25, 2024 17:52
Copy link
Contributor

@tadeohepperle tadeohepperle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
This PR backports the changes from
paritytech/json-rpc-interface-spec#107.

The `transaction` class becomes `transactionWatch`, and the other
functionality remains the same.

// cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants