Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts: Stabilize caller_is_root API #3154

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Contracts: Stabilize caller_is_root API #3154

merged 3 commits into from
Feb 3, 2024

Conversation

xermicus
Copy link
Member

Can this API be marked stable? Implemented in solang here

@xermicus
stabilize caller_is_root API
8e736cf 
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus xermicus requested a review from pgherveou January 31, 2024 10:08
@xermicus xermicus requested a review from athei as a code owner January 31, 2024 10:08
@xermicus
prdoc
5a25a77 
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus xermicus added the T7-smart_contracts This PR/Issue is related to smart contracts. label Jan 31, 2024
@xermicus
fix prdoc
193da7c 
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
pgherveou
pgherveou reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@pgherveou pgherveou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be added to ink! integration tests first

athei
athei approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO an integration test in solang is fine, too. We were just saying we need an integration test in ink! because we just assumed they would implement it first. If it works for Solidity it should definitely work for ink!. That said, if it were a more complex function (like XCM) we would probably want both implementations.

@pgherveou
Copy link
Contributor

IMHO an integration test in solang is fine, too. We were just saying we need an integration test in ink! because we just assumed they would implement it first. If it works for Solidity it should definitely work for ink!. That said, if it were a more complex function (like XCM) we would probably want both implementations.

@xermicus maybe add a ticket to add a Test for the ink! team so we don't forget

@athei athei added this pull request to the merge queue Feb 3, 2024
@athei athei mentioned this pull request Feb 3, 2024
Open
Merged via the queue into master with commit 966a886 Feb 3, 2024
126 checks passed
@athei athei deleted the cl/stabilize-caller-is-root branch February 3, 2024 12:39
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@xermicus
Contracts: Stabilize caller_is_root API (paritytech#3154)
2981d9f 
Can this API be marked stable? Implemented in [solang
here](hyperledger-solang/solang#1620)

---------

Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
@chungquantin chungquantin mentioned this pull request Aug 4, 2024
Closed
4 tasks
@chungquantin chungquantin mentioned this pull request Aug 12, 2024
Merged
4 tasks
@Aideepakchaudhary Aideepakchaudhary mentioned this pull request Oct 14, 2024
Closed
@olahfemi olahfemi mentioned this pull request Dec 2, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athei athei athei approved these changes

@pgherveou pgherveou pgherveou approved these changes

Assignees
No one assigned
Labels
T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xermicus @pgherveou @athei