Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: add prdoc for 3370 #3401

Merged
merged 4 commits into from
Feb 20, 2024
Merged

nit: add prdoc for 3370 #3401

merged 4 commits into from
Feb 20, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Feb 20, 2024

Did not realize that #3370 was indeed breaking. cc @muraca

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Feb 20, 2024
@bkchr bkchr enabled auto-merge February 20, 2024 13:16
doc:
- audience: Runtime Dev
description: |
Removed the `key` getter function from the sudo pallet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to name what function replaced this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is at the moment there's no other function.

#3370 (comment)

Copy link
Member Author

@ggwpez ggwpez Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just removed. Will mention that.

@bkchr bkchr disabled auto-merge February 20, 2024 13:17
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez enabled auto-merge February 20, 2024 17:11
@ggwpez ggwpez disabled auto-merge February 20, 2024 17:11
prdoc/pr_3370.prdoc Outdated Show resolved Hide resolved
@ggwpez ggwpez added this pull request to the merge queue Feb 20, 2024
Merged via the queue into master with commit 60563b8 Feb 20, 2024
128 of 130 checks passed
@ggwpez ggwpez deleted the oty-sudo-prdoc branch February 20, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants