Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prdoc: Print errors on CI #3459

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Feb 23, 2024

By passing RUST_LOG=info to the check command, we will be able to see the exact problem with a given prdoc.

Before:

PR #3243 -> ERR

After:

[2024-02-23T12:53:55Z INFO  prdoclib::commands::check] Checking directory prdoc
[2024-02-23T12:53:55Z INFO  prdoclib::commands::check] Using schema: /Users/sebastian/work/repos/polkadot-sdk/prdoc/schema_user.json
[2024-02-23T12:53:55Z WARN  prdoclib::schema] validation_result: false
[2024-02-23T12:53:55Z WARN  prdoclib::schema] validation_result_strict: false
[2024-02-23T12:53:55Z WARN  prdoclib::schema] errors: [
        Required {
            path: "/title",
        },
    ]
[2024-02-23T12:53:55Z WARN  prdoclib::schema] missing: []
[2024-02-23T12:53:55Z ERROR prdoclib::commands::check] Loading the schema failed:
[2024-02-23T12:53:55Z ERROR prdoclib::commands::check] ValidationErrors(ValidationState { errors: [Required { path: "/title" }], missing: [], replacement: None, evaluated: {"/doc/0/description", "/crates/0/name", "/doc/0", "/crates", "/crates/0", "", "/doc", "/doc/0/audience"} })
PR #3243 -> ERR

@skunert skunert added the R0-silent Changes should not be mentioned in any release notes label Feb 23, 2024
@skunert skunert requested review from a team as code owners February 23, 2024 12:55
@skunert skunert added T0-node This PR/Issue is related to the topic “node”. and removed R0-silent Changes should not be mentioned in any release notes labels Feb 23, 2024
This reverts commit ef26731.
@skunert skunert added R0-silent Changes should not be mentioned in any release notes and removed T0-node This PR/Issue is related to the topic “node”. labels Feb 23, 2024
@skunert skunert requested a review from bkchr February 23, 2024 13:02
@bkchr bkchr merged commit 64050cf into paritytech:master Feb 23, 2024
20 of 37 checks passed
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: build-linux-stable-cumulus
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5326058

@skunert skunert deleted the skunert/prdoc_log branch March 27, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants