Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts: Remove unstable on lock/unlock_delegate_dependency host fns #3606

Merged

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Mar 7, 2024

Oversight from PR #3384.
These 2 functions should have been tagged as stable

@pgherveou pgherveou requested a review from athei as a code owner March 7, 2024 09:34
Copy link

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anything needed for prdoc?

@pgherveou pgherveou added the T7-smart_contracts This PR/Issue is related to smart contracts. label Mar 7, 2024
@pgherveou
Copy link
Contributor Author

@ParityReleases Any chance we can push this to v1.8.0, this was an oversight from this PR #3384 that went trhough in this release

@pgherveou pgherveou requested a review from xermicus March 7, 2024 09:49
@pgherveou pgherveou changed the title remove unstable on lock/unlock_delegate_dependency host fns Contracts: Remove unstable on lock/unlock_delegate_dependency host fns Mar 7, 2024
@pgherveou pgherveou enabled auto-merge March 7, 2024 09:51
@pgherveou pgherveou added this pull request to the merge queue Mar 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 7, 2024
@pgherveou pgherveou added this pull request to the merge queue Mar 7, 2024
@athei athei removed this pull request from the merge queue due to a manual request Mar 7, 2024
@athei athei added this pull request to the merge queue Mar 7, 2024
@athei
Copy link
Member

athei commented Mar 7, 2024

Sorry was my miss click.

Merged via the queue into master with commit de9411a Mar 7, 2024
132 of 133 checks passed
@athei athei deleted the pg/remove-unstable-on-lock-unlock_delegate_dependency-host-fns branch March 7, 2024 13:12
github-merge-queue bot pushed a commit that referenced this pull request Mar 8, 2024
ApiVersion should have been bumped with
#3606
this does that and add a test so we don't forget to do that everytime
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
paritytech#3606)

Oversight from PR paritytech#3384.
These 2 functions should have been tagged as stable
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
ApiVersion should have been bumped with
paritytech#3606
this does that and add a test so we don't forget to do that everytime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants