Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCM Fee Payment Runtime API #3607
XCM Fee Payment Runtime API #3607
Changes from 25 commits
c471add
137d129
c4b070b
6bc4e95
c649ad2
1b93e2a
16d9d22
a8337b9
7b17ece
f6201bf
55b1a03
707f0b0
a27c70f
f45f9dd
18e54e7
4caea72
e348602
fc06767
60a88a6
fee8d7b
cceafd4
618f17f
4a83147
e7c752a
3ce306f
ddae561
25252b8
3cd6503
32ea4f5
81b7e39
d706cd0
fc3ca43
f9f3f67
6287558
4fe5985
c04e4d8
1cc0119
ea964fb
01942ea
d5ed17b
faba8a1
e02f957
01857a4
806f29d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A client might not understand the returned XCM version. The returned
VersionedAssets
should follow the version of one of the inputs. For instance, if thedestination
and themessage
are both v3, the returned assets should also be in the v3 form.The current code will always return the form of the latest XCM version, which might break some clients (no one uses this API at the moment, but IMHO, we need a proper way of handling this for future XCM versions).
For the same reason, we have the
xcm_version
parameter in thequery_acceptable_payment_assets
method.Another question, though: what if the
destination
and themessage
are expressed via different XCM versions? What version should the returned assets follow?The same goes for Westend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
use the newest version between them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. The implementation is located in pallet-xcm, as per the comment below.
I added the
IdentifyVersion
implementation forVersionedXcm
to implement the "use the newest version between them" logic