Deprecate xcm::body::TREASURER_INDEX constant, use standard Treasury varian instead #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
added
R0-silent
bkontur
approved these changes
Mar 7, 2024
| @@ -130,6 +130,8 @@ pub mod xcm { | |||
| const ROOT_INDEX: u32 = 0; | |||
| // The bodies corresponding to the Polkadot OpenGov Origins. | |||
| pub const FELLOWSHIP_ADMIN_INDEX: u32 = 1; | |||
| #[deprecated = "Will be removed after August 2024; Use `xcm::latest::BodyId::Treasury` \ | |||
There was a problem hiding this comment.
to make sure none uses the same index for the time of deprecation
georgepisaltu
approved these changes
Mar 7, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
xcm::body::TREASURER_INDEXconstant and use the standard Treasury variant from thexcm::BodyIdtype instead.To align with the production runtimes: polkadot-fellows/runtimes#149