Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SortedMembers::add for pallet-membership benchmarks #3729

Merged
merged 6 commits into from
Apr 2, 2024
Merged

SortedMembers::add for pallet-membership benchmarks #3729

merged 6 commits into from
Apr 2, 2024

Conversation

Dinonard
Copy link
Contributor

Adds implementation for SortedMembers::add for pallet-membership benchmarks.

@Dinonard Dinonard requested a review from a team as a code owner March 18, 2024 10:49
@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Mar 18, 2024
@Dinonard Dinonard mentioned this pull request Mar 22, 2024
Merged
@Dinonard
Copy link
Contributor Author

Can we please get another approval? 🙂

@ggwpez ggwpez requested a review from a team March 22, 2024 18:19
@Dinonard
Copy link
Contributor Author

Dinonard commented Apr 2, 2024

Please someone provide another approval (or comment). Thanks!

@ggwpez
Copy link
Member

ggwpez commented Apr 2, 2024

Reviewing changes here is currently mainly done by Parity, but it does not scale. Will ping it in the Polkadot Technical Fellowship - Open Channel.

bkchr
bkchr approved these changes Apr 2, 2024
View reviewed changes
substrate/frame/membership/src/lib.rs Outdated Show resolved Hide resolved
@ggwpez
Copy link
Member

ggwpez commented Apr 2, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Apr 2, 2024 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5739019 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-6876e9db-0c15-4f09-995e-0704fd115d8a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 2, 2024

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5739019 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5739019/artifacts/download.

@bkchr bkchr enabled auto-merge April 2, 2024 18:50
@bkchr bkchr added this pull request to the merge queue Apr 2, 2024
Merged via the queue into paritytech:master with commit f88190a Apr 2, 2024
131 of 133 checks passed
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
@Dinonard @bkchr @Ank4n
SortedMembers::add for pallet-membership benchmarks (#3729)
67de6ed 
Adds implementation for `SortedMembers::add` for _pallet-membership_
benchmarks.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
@Dinonard @bkchr @dharjeezy
SortedMembers::add for pallet-membership benchmarks (paritytech#3729)
25edb47 
Adds implementation for `SortedMembers::add` for _pallet-membership_
benchmarks.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@wirednkod wirednkod wirednkod approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dinonard @ggwpez @wirednkod @bkchr