Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addresses_to_publish_respects_existing_p2p_protocol test in sc-authority-discovery #3895

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

dmitry-markin
Copy link
Contributor

Fixes #3887.

@dmitry-markin dmitry-markin added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”. labels Mar 29, 2024
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandreim sandreim added this pull request to the merge queue Mar 29, 2024
Merged via the queue into master with commit 0d93248 Mar 29, 2024
139 of 145 checks passed
@sandreim sandreim deleted the dm-authority-discovery-peer-id-test branch March 29, 2024 13:39
pgherveou pushed a commit that referenced this pull request Apr 2, 2024
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sc-authority-discovery: test addresses_to_publish_respects_existing_p2p_protocol broken
3 participants