-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple fees for reserve_transfer_assets #3918
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pallet order * fmt * adds test for bridge order * revert unintended change --------- Co-authored-by: claravanstaden <Cats 4 life!>
* fix coverage * fix codecov config --------- Co-authored-by: claravanstaden <Cats 4 life!>
# Conflicts: # .github/workflows/check-labels.yml # .github/workflows/check-prdoc.yml # .github/workflows/check-workspace.yml # .github/workflows/gitspiegel-trigger.yml # .github/workflows/release-99_notif-published.yml # bridges/snowbridge/README.md # bridges/snowbridge/runtime/test-common/src/lib.rs # bridges/snowbridge/scripts/contribute-upstream.sh # cumulus/parachains/runtimes/assets/test-utils/src/test_cases_over_bridge.rs # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/tests/snowbridge.rs # polkadot/node/subsystem-bench/src/approval/mod.rs # polkadot/node/subsystem-bench/src/availability/mod.rs # polkadot/node/subsystem-bench/src/cli.rs # polkadot/node/subsystem-bench/src/core/environment.rs # polkadot/node/subsystem-bench/src/subsystem-bench.rs
* extract ethereum chain id * remove cargo.toml * fix chain id data type * fix missing chain id param * fix missing chain id param * fix coverage and missing param * fix CI * fix CI * revert scripts * revert coverage jobs * revert formatting --------- Co-authored-by: claravanstaden <Cats 4 life!>
* Ignore rewarding when funds unavailable * More tests * Fix taplo * Fix emulated test * Improve comments * Update bridges/snowbridge/pallets/inbound-queue/src/lib.rs Co-authored-by: Vincent Geddes <vincent@snowfork.com> * Fix format --------- Co-authored-by: Vincent Geddes <vincent@snowfork.com>
* test e2e scripts in GA * fix GA * test current dir * fix path * install moreutils * sponge * install go * export path * try something else * run nix * switch branch * nix develop * check setup * use nix setup * e2e stack script * e2e stack script * run command * check current dir * correct dir * correct dir * just cd * try something else * rn e2e script * adds submodules * ls * print vars * remove ls * cd instead of pushdir * try checking out differently * ls * ls * change checkout order * check what is in a dir * check what is in a dir * check something * check something * try something * try something * try e2e script again * remove ls * cleanup script * adds ssz gen * install js components * install js components * fix dir * adds output dir * create dir * try something else * bump * fix config paths * test output dir * adds wasm target * check wasm target * setup rustup in nix * missing quote * install rustup stable * adds e2e script in again * remove skip wasm flag * comment out things * start lodestar * print out log * print out log * print out lodestar * check geth version * bump * remove commented out code * update go files * adds smoketests * create dir * adjust scripts * only redirect start-services.sh output * only redirect start-services.sh output * switch dir * permissions * check script * allow service to be down * bump * last run, hopefully * fix tests * fixes * bump * fix * check lodestar * check lodestar * check lodestar * bump * bump * try again * try again * bump * bump * update go * update go * cleanup * check what is happening now * lodestar should run the background * run init.sh * check what happens with the download * change OS check * remove other steps to see what is happening * bump * run smoketests * run smoketests * cleanup jobs * extract ethereum chain id * remove cargo.toml * fix chain id data type * fix missing chain id param * fix missing chain id param * fix coverage and missing param * fix CI * fix CI * revert scripts * revert coverage jobs * revert formatting * check log * fix log * separate steps * cleanup job * remove running smoketests on a PR, only when merged * update branch * remove http endpoint from relayer * update nightly, revert unrelated changes * check rust version * chaneg branch for testing * adds beacon relay log * increase slot time * increase block time check * lower block check count * only run smoketests on merge to snowbridge --------- Co-authored-by: claravanstaden <Cats 4 life!>
* Sync execution update on demand * Fix updating LatestExecutionState * Revert change unrelated * Remove unused * Remove execution header from update & Remove LatestExecutionState
* adds finalized header gap check * fix comment * fmt * use constant for max gap * remove redundant config * fmt * fix tests * fix again * fmt * test works * revert change * Update bridges/snowbridge/pallets/ethereum-client/src/lib.rs Co-authored-by: Vincent Geddes <vincent@snowfork.com> * fmt --------- Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: Vincent Geddes <vincent@snowfork.com>
…ion header storage (#125) * Remove execution header storage & submit inbound message with execution update * Fix ci breaking * More refactoring * Update beacon test fixtures * Format code * Initialize storage with finalized checkpoint for benchmark * Update weights include verify the execution proof * Fix breaking test * Remove fixture not in use * Add detail for InvalidExecutionProof * Initialize checkpoint for tests on demand * Revert error as NotBootstrapped for submit_update_with_missing_bootstrap * Add verify_execution_header tests back * Add error test back * Cleanup templates * Update bridges/snowbridge/primitives/beacon/src/types.rs Co-authored-by: Vincent Geddes <vincent@snowfork.com> * Narrowed inputs * Remove fields irrelevant from proof * Update bridges/snowbridge/primitives/core/src/inbound.rs Co-authored-by: Vincent Geddes <vincent@snowfork.com> * Update bridges/snowbridge/pallets/ethereum-client/src/impls.rs Co-authored-by: Vincent Geddes <vincent@snowfork.com> * Polish --------- Co-authored-by: Vincent Geddes <vincent@snowfork.com>
* fix smoketests ci * remove merge from upstream * first commit before pulling from master --------- Co-authored-by: claravanstaden <Cats 4 life!>
* Add fee multiplier * fmt * fmt * Update test mock * Swap order for parameters to calculate_fee --------- Co-authored-by: claravanstaden <Cats 4 life!>
# Conflicts: # .github/scripts/check-workspace.py # .github/scripts/common/lib.sh # .github/workflows/check-licenses.yml # .github/workflows/check-prdoc.yml # .github/workflows/release-50_publish-docker.yml # .github/workflows/release-99_notif-published.yml # Cargo.lock # bridges/snowbridge/pallets/ethereum-client/Cargo.toml # bridges/snowbridge/pallets/ethereum-client/src/tests.rs # bridges/snowbridge/pallets/inbound-queue/Cargo.toml # bridges/snowbridge/pallets/inbound-queue/src/mock.rs # bridges/snowbridge/pallets/outbound-queue/Cargo.toml # bridges/snowbridge/pallets/outbound-queue/merkle-tree/Cargo.toml # bridges/snowbridge/pallets/outbound-queue/runtime-api/Cargo.toml # bridges/snowbridge/pallets/outbound-queue/src/lib.rs # bridges/snowbridge/pallets/system/Cargo.toml # bridges/snowbridge/pallets/system/runtime-api/Cargo.toml # bridges/snowbridge/primitives/beacon/Cargo.toml # bridges/snowbridge/primitives/core/Cargo.toml # bridges/snowbridge/primitives/ethereum/Cargo.toml # bridges/snowbridge/runtime/runtime-common/Cargo.toml # bridges/snowbridge/runtime/test-common/Cargo.toml
# Conflicts: # .github/CODEOWNERS # .github/scripts/common/lib.sh # bridges/snowbridge/pallets/ethereum-client/src/tests.rs # bridges/snowbridge/pallets/inbound-queue/fixtures/src/register_token_with_insufficient_fee.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Snowfork#128 (comment)