Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust zombienet test resources and logic #4032

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Apr 8, 2024

One more try to make this test robust from a resource perspective.

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. labels Apr 8, 2024
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Copy link
Contributor Author

sandreim commented Apr 9, 2024

Got 2 succesfull runs, but 3rd was really bad:

image

@pepoviola
Copy link
Contributor

Small update: Our hunch is that the intermittent failures are due to the performance of the vms disks we currently use, we are going to add a new tier to the cluster with more performing disks to run these tests. We will be doing this work tonight at midnight.
Thx!

@sandreim sandreim requested a review from a team as a code owner April 10, 2024 08:25
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Copy link
Contributor Author

I'll think of a better more flexible way to ensure this gives confidence elastic scaling is working while also not depending on the speed of infra. However we should keep the new infra changes.

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim changed the title Adjust zombienet test resources Adjust zombienet test resources and logic Apr 11, 2024
@sandreim
Copy link
Contributor Author

Tried many times and it looks stable now. I'd say we should merge it.

@pepoviola
Copy link
Contributor

Tried many times and it looks stable now. I'd say we should merge it.

I tried a couple of time more and works as expected :)

@sandreim sandreim added this pull request to the merge queue Apr 12, 2024
Merged via the queue into master with commit 13ca339 Apr 12, 2024
134 of 137 checks passed
@sandreim sandreim deleted the sandreim/are_we_overcommitting_the_cluster branch April 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants